From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id A13BB6DE0C66 for ; Thu, 12 Oct 2017 07:07:22 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.045 X-Spam-Level: X-Spam-Status: No, score=-0.045 tagged_above=-999 required=5 tests=[AWL=-0.045] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rxEwH-vDjrkX for ; Thu, 12 Oct 2017 07:07:21 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTP id BB5996DE0A9A for ; Thu, 12 Oct 2017 07:07:21 -0700 (PDT) Received: from fifthhorseman.net (unknown [38.109.115.130]) by che.mayfirst.org (Postfix) with ESMTPSA id 4955FF99A; Thu, 12 Oct 2017 10:07:18 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id C5365205EB; Thu, 12 Oct 2017 10:07:13 -0400 (EDT) From: Daniel Kahn Gillmor To: David Bremner , Notmuch Mail Subject: Re: [PATCH v3 04/15] crypto: move into libutil In-Reply-To: <87vajkmyae.fsf@tethera.net> References: <20170915055359.24123-1-dkg@fifthhorseman.net> <20171010054916.23925-1-dkg@fifthhorseman.net> <20171010054916.23925-5-dkg@fifthhorseman.net> <87vajkmyae.fsf@tethera.net> Date: Thu, 12 Oct 2017 10:07:10 -0400 Message-ID: <87d15sfoj5.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Oct 2017 14:07:22 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Bremner-- Thanks for the review! On Thu 2017-10-12 07:54:33 -0300, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> This prepares us for using the crypto object in both the library and >> the client. > > I think we could be more precise about names here, to help outsiders get > up to speed on the code. libutil was renamed to libnotmuch_util, and > "the library" should probably be "libnotmuch". Are you asking for improved comment text in the git commit, or for something else? I'm happy to provide improved comment text, if that's what you're asking for. >> diff --git a/crypto.c b/util/crypto.c >> similarity index 97% >> rename from crypto.c >> rename to util/crypto.c >> index 4c1b7eec..39954ca0 100644 >> --- a/crypto.c >> +++ b/util/crypto.c >> @@ -18,7 +18,11 @@ >> * Authors: Jameson Rollins >> */ >>=20=20 >> -#include "notmuch-client.h" >> +#include "crypto.h" >> +#include "lib/notmuch-private.h" >> + > > This seems like a kind of layering violation. What's in > notmuch-private.h that needs to be exported to things outside of lib/ ? when building against gmime-3.0, this #include supplies: #define unused(x) x __attribute__ ((unused)) When building against gmime-2.6, it provides: #include I could replace it with these two things explicitly (and i could put them inside the GMIME_MAJOR_VERSION tests) if that would be preferable to #including lib/notmuch-private.h. Any preference? --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEOCdgUepHf6PklTkyFJitxsGSMjcFAlnfdw4ACgkQFJitxsGS MjcmBhAAjVoOY8dj3O1FajlOJ9r+q1mzlk0LMRxuB5BIPq7g1eRSd9ZKZM8SMmwh CkZFNa3YlH1c0aab7nxx3r9kppfsPMMTV5w0rqmD+DxU6R1fxUrsyoj7wAZ6kxEY TED5+qIWYpnUcrfUN9jnHtblf193ymGLmrPAo9pLm/diyYZY6cwQM190XgNPOWoZ tKvsraSsdGUiXLRENDwh1v5bMBSOIPHmZrcL0BdERo2WOgIURHnI+RnImZnSR2D4 TnOtPVvCVH8ePyNxJGvva0CSkaM/r/oWr/g1IEWFxCMbjXPam3M68Lp4HesrpsgB rjs4jwzMfBg2yYIyWg1Wkr46JsfQb4bMIxgpwVigSo3g0zq5RzGkh4tVxl27+CBq OBsqVWvtv0QYpthmY3vOAQvb4wm63fX8ws4cGysWbF5x0DU3/HLZri8JhTHSnW/B VI9DYzu6HobJtdORjFQ7lh+O0zilQOoIrabk8zqTYKbavN0C53TFmpvfS8YauOQq CDVMl0HO9cO2FSfz9WWsiux5ApBweS2gk5ZLYN9w5qnTyNedJyJtKC2ZpN27dE1p 0wbwoy90P5jmSfpCNFV/kw5wlFm8f8RROk03vvGNIBIwBoIikJfV5jPXRrjMAJsg W4HDDX41uCm7jiOo32kMo/ZYOV6z0HnybyeZ/hSAbpEO7RqgkfI= =rHoS -----END PGP SIGNATURE----- --=-=-=--