From: David Bremner <david@tethera.net>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v1 2/2] emacs: Call `notmuch-mua-send-hook' hooks when sending a message
Date: Fri, 28 Sep 2018 21:12:53 -0300 [thread overview]
Message-ID: <87d0sx2mbe.fsf@tethera.net> (raw)
In-Reply-To: <87pnwz3ei5.fsf@tethera.net>
David Bremner <david@tethera.net> writes:
>
> This looks plausible to me, and of course the test passes. I did wonder
> if this means that people actually using notmuch-user-agent would run
> the hook twice now?
After a certain amount of re-reading the docstring of
define-mail-user-agent, and the source for compose-mail, I see that the
HOOKVAR parameter is something that users of the mail-agent can tweak,
rather than something that e.g. compose-mail promises to run. So I think
your patch is fine. And I'm 99% sure the issue with the spurious output
is just a little bug in test-lib.sh
d
next prev parent reply other threads:[~2018-09-29 0:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 15:09 [PATCH v1 0/2] `notmuch-mua-send-hook' was ignored David Edmondson
2018-09-25 15:09 ` [PATCH v1 1/2] test: Check that `notmuch-mua-send-hook' is called on sending a message David Edmondson
2018-09-27 1:29 ` David Bremner
2018-09-25 15:09 ` [PATCH v1 2/2] emacs: Call `notmuch-mua-send-hook' hooks when " David Edmondson
2018-09-27 1:39 ` David Bremner
2018-09-29 0:12 ` David Bremner [this message]
2018-09-30 1:06 ` David Bremner
2018-10-01 9:56 ` David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0sx2mbe.fsf@tethera.net \
--to=david@tethera.net \
--cc=dme@dme.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).