From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qLGpLighu16RVgAA0tVLHw (envelope-from ) for ; Tue, 12 May 2020 22:20:24 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WMbCDzchu17kbQAAbx9fmQ (envelope-from ) for ; Tue, 12 May 2020 22:20:39 +0000 Received: from arlo.cworth.org (unknown [50.126.95.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E0A4A940609 for ; Tue, 12 May 2020 22:20:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 128CF6DE1385; Tue, 12 May 2020 15:20:22 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U_oNJFZI82gK; Tue, 12 May 2020 15:20:21 -0700 (PDT) Received: from arlo.cworth.org (localhost [IPv6:::1]) by arlo.cworth.org (Postfix) with ESMTP id 169466DE136E; Tue, 12 May 2020 15:20:20 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 99F416DE1386 for ; Tue, 12 May 2020 15:20:18 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Pszw01e0yqe7 for ; Tue, 12 May 2020 15:20:17 -0700 (PDT) Received: from che.mayfirst.org (unknown [162.247.75.117]) by arlo.cworth.org (Postfix) with ESMTPS id 67CA96DE10AA for ; Tue, 12 May 2020 15:20:17 -0700 (PDT) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1589322016; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=GYp9HAvPL4K86kgWbFDBfjv9ulx7sSRtsh7qnfRYDlk=; b=KM0jrXgBjBDPiLpiX7wZzO92T6gvWM46+n5oslFAQKGL267cyTAtu8+S/DGJhaaKKJfKY FkgOVMU56+rZSoUDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1589322016; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=GYp9HAvPL4K86kgWbFDBfjv9ulx7sSRtsh7qnfRYDlk=; b=Lb8/SdxOxpQSu9rXVt9JyhnJK6jfWzMAjnX4cWLr99k8eINQAnQLPeeVqozYgnDN8Ey7L MVhNid9FfXbJz9N4G5W//WtXDBfWJw6+qc9Uk0d3gX+ulZ/tvN8wY+qDu09shLMuh9MGc/k KfCyAEI1JKp+5Rzp9dCMQQ6P+VP2jNeyprsnz9M7hms1kN0fyRqDROh8UVI7WpIuF6N7euq se81tGjlcyB/YE643xo+ymC0Av3VfUQetlWe8BwVubjnbW09yomrBdqGvoGHbKkyoXwdozS Do+5+Sy7IVCfW/1UN2HEetZToEPzRPZFPC+/QrTUn9lYIjOOIKO8+p+Nv2dg== Received: from fifthhorseman.net (unknown [108.58.6.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 1AC3DF9A5; Tue, 12 May 2020 18:20:13 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 3E15520624; Tue, 12 May 2020 18:14:41 -0400 (EDT) From: Daniel Kahn Gillmor To: David Bremner , Notmuch Mail Subject: Re: [PATCH 1/2 v2] test-lib: mark function variables as local In-Reply-To: <87r1vtib41.fsf@tethera.net> References: <20200506235438.100518-1-dkg@fifthhorseman.net> <20200508232438.169867-1-dkg@fifthhorseman.net> <87r1vtib41.fsf@tethera.net> Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEXEK/AhYJKwYBBAHaRw8BAQdAr/gSROcn+6m8ijTN0DV9AahoHGafy52RRkhCZVwxhEe0K0Rh bmllbCBLYWhuIEdpbGxtb3IgPGRrZ0BmaWZ0aGhvcnNlbWFuLm5ldD6ImQQTFggAQQIbAQULCQgH AgYVCgkICwIEFgIDAQIeAQIXgAIZARYhBMS8Lds4zOlkhevpwvIGkReQOOXGBQJd5Hw3BQkFpJWB AAoJEPIGkReQOOXGDYEA/j0ERjPxDleKMZ2LDcWc/3o5cLFwAVzBKQHppu0Be5IWAP0aeTnyEqlp RTE7M8zugwkhYeUYfYu0BjecDUMnYz6iDLgzBF3kewUWCSsGAQQB2kcPAQEHQK1IuW0GZmcrs2mx CYMl8IHse0tMF8cP7eBNXevrlx2ZiPUEGBYIACYCGwIWIQTEvC3bOMzpZIXr6cLyBpEXkDjlxgUC XeR7TwUJAiGl/gCBdiAEGRYIAB0WIQQsv6x2UaqQJzY+dXHEDyVUMvKBDwUCXeR7BQAKCRDEDyVU MvKBD7KmAQCHs+7588C4jto6fMje0Nu97zzoppjJM7lrGF2rVnbHvwD+MgmGUbHzPSUrTWnZBQDi /QM595bxNrBA4N1CiXhs2AMJEPIGkReQOOXGpp0BAM7YeBnt/UNvxJAGm4DidSfHU7RDMWe6Tgux HrH21cDkAQC9leNFXJsQ7F2ZniRPHa8CkictcQEKPL8VCWpfe8LbArg4BF3ke5wSCisGAQQBl1UB BQEBB0Cf+EiAXtntQMf51xpqb6uZ5O0eCLAZtkg0SXHjA1JlEwMBCAeIfgQYFggAJhYhBMS8Lds4 zOlkhevpwvIGkReQOOXGBQJd5HucAhsMBQkCIaVkAAoJEPIGkReQOOXGdYcBANYnW7VyL2CncKH1 iO4Zr0IwfdIv6rai1PUHL98pVi3cAP9tMh85CKGDa0Xi/fptQH41meollLW5tLb/bEWMuUNuBQ== Date: Tue, 12 May 2020 18:14:40 -0400 Message-ID: <87d078n6lr.fsf@fifthhorseman.net> MIME-Version: 1.0 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Ollila Content-Type: multipart/mixed; boundary="===============1771042027143083773==" Errors-To: notmuch-bounces@notmuchmail.org Sender: "notmuch" X-Scanner: scn0 X-Spam-Score: 1.49 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=fifthhorseman.net header.s=2019 header.b=KM0jrXgB; dkim=fail (body hash did not verify) header.d=fifthhorseman.net header.s=2019rsa header.b=Lb8/SdxO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fifthhorseman.net (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 50.126.95.6 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Scan-Result: default: False [1.49 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.44794352203134]; RDNS_NONE(1.00)[]; DWL_DNSWL_BLOCKED(0.00)[50.126.95.6:from]; R_SPF_ALLOW(-0.20)[+a:c]; IP_REPUTATION_HAM(0.00)[asn: 27017(-0.18), country: US(-0.00), ip: 50.126.95.6(-0.45)]; R_DKIM_REJECT(1.00)[fifthhorseman.net:s=2019,fifthhorseman.net:s=2019rsa]; FORGED_SENDER_MAILLIST(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[fifthhorseman.net:-]; MX_GOOD(-0.50)[notmuchmail.org]; MAILLIST(-0.20)[mailman]; SIGNED_PGP(-2.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+,3:~,4:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:27017, ipnet:50.126.64.0/18, country:US]; FROM_NEQ_ENVFROM(0.00)[dkg@fifthhorseman.net,notmuch-bounces@notmuchmail.org]; MID_RHS_MATCH_FROM(0.00)[]; RDNS_DNSFAIL(0.00)[]; ARC_NA(0.00)[]; URIBL_BLOCKED(0.00)[notmuchmail.org:email]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MIME_GOOD(-0.20)[multipart/mixed,multipart/signed,text/plain]; PREVIOUSLY_DELIVERED(0.00)[notmuch@notmuchmail.org]; HAS_LIST_UNSUB(-0.01)[]; DNSWL_BLOCKED(0.00)[50.126.95.6:from]; RCVD_COUNT_SEVEN(0.00)[8]; HFILTER_HOSTNAME_UNKNOWN(2.50)[]; DMARC_POLICY_SOFTFAIL(0.10)[fifthhorseman.net : SPF not aligned (relaxed),none] X-TUID: GLT/JtKVPcUd --===============1771042027143083773== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain On Sat 2020-05-09 08:47:10 -0300, David Bremner wrote: > I'm confused about where to apply 2/2. If I apply it on top of (updated) > master, it causes test failures. If I apply after the rest of the > patches in this thread then presumably there is some interval where the > build is broken (if only for certain GMime versions). fwiw, i believe that the current master ( 627460d7bbbb6b95a07084c2b6fc7f647a5547e1 ) *is* broken on systems with older gmime. In particular, on debian buster, i see: T356-protected-headers: Testing Message decryption with protected headers FAIL verify signed PKCS#7 subject (multipart-signed) sig_uid: object not found: data[0][0][0]["crypto"]["signed"]["status"][0]["userid"] My [PATCH v2/2 v2] in this thread (sent shortly) should resolve this situation. Then, i'll send a rebased version of the full S/MIME series in a new thread. --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQQsv6x2UaqQJzY+dXHEDyVUMvKBDwUCXrsf0AAKCRDEDyVUMvKB D07cAQDLfXZ0qzdtvuKHe7MfaUOTnhdp+waxPGD4c+kWd9YrpQD/Z66nmowd3Qxk cgScFwxjPwN+P553m9cPiEpSfEXAXQc= =H/oe -----END PGP SIGNATURE----- --=-=-=-- --===============1771042027143083773== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============1771042027143083773==--