From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oAHGEAd/yV6RTQAA0tVLHw (envelope-from ) for ; Sat, 23 May 2020 19:52:39 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id GN+hDAd/yV7SJAAAB5/wlQ (envelope-from ) for ; Sat, 23 May 2020 19:52:39 +0000 Received: from arlo.cworth.org (arlo.cworth.org [50.126.95.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D567294042C for ; Sat, 23 May 2020 19:52:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 6E1A86DE0EC6; Sat, 23 May 2020 12:52:28 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cVJimMMybOcL; Sat, 23 May 2020 12:52:27 -0700 (PDT) Received: from arlo.cworth.org (localhost [IPv6:::1]) by arlo.cworth.org (Postfix) with ESMTP id 360D76DE0ECA; Sat, 23 May 2020 12:52:27 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 1801D6DE0ECA for ; Sat, 23 May 2020 12:52:26 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3lPS-96sFCiQ for ; Sat, 23 May 2020 12:52:23 -0700 (PDT) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by arlo.cworth.org (Postfix) with ESMTPS id 81F0A6DE0EC6 for ; Sat, 23 May 2020 12:52:23 -0700 (PDT) Received: by mail-ed1-f45.google.com with SMTP id k19so11961190edv.9 for ; Sat, 23 May 2020 12:52:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:in-reply-to:references:date:message-id :mime-version; bh=+/olGFVZnvXFwcjGuiX4tibQsupwfhttfdAXEmhQRKg=; b=b/Dx/kK45uDZceomU+5J/VwlmSYzaMUyZksPPDPxziwj6FsJBskypqSxzI1we76Hka FIpHkWfEMuNFNCBx8/SlRkkMaOapFH8hcX4mLAtQsgdpVox5ojS8vQCxsUfp5+4qO78E kBTgJvf3RT68ron5iWtq0AYXj9HCZchvWbtlgsDfsy7/hl2+m1F7hofyikx+O4Wk2uO+ x8TjdPaxl0C/jYuEFNDexE4to3NrpE28X+6cxNpmoeDjO895TNLGqH/y2PuuUyQG/KfP 1WsgBwZnP4U6etG43DOqYfDaLW3f7/Kkz3umBS8CdheROLO9whEAfdzLBZSu3KTDkugG /gCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:in-reply-to:references :date:message-id:mime-version; bh=+/olGFVZnvXFwcjGuiX4tibQsupwfhttfdAXEmhQRKg=; b=moXfUDLQ5nlI30Xko85xeVhWQU4zO/o9rGrsNC3B6st+rvi3TMcrzXrFuKzrxQ22Oj CJedQ+yIxKNv4QO1pFholvf8LpduxX8tU0iLzyQ43CMCAGORhfzApyqmr0XUIgQ0Nwez yTKLSjZ9d9OJSvAyujsxzT2pQajBoa86rTN8lFWCD9JIgNDz9kZT6ln60WE/yLd3DhqD 9uGdjKGQmGtt0tbhUi714C3mEcuGdaqXgybclaRiNQ2xkubgAl7bgoL1zZguq4Y/W6NP rhdy96SlPDRC9hkdwBNStqMj4A7zEUfA/tZGQasAFdNT04Gf4P4vm7M3UnDi+nkbM3Vk TcpA== X-Gm-Message-State: AOAM531ZrKbQV4sim9Z00AQUtJZIeDtL0FkH6Fks6XoWK5FnAVc2gEhV lTvvH168nDWanMskAGUK6TU= X-Google-Smtp-Source: ABdhPJyorJ8B3ni2Eech0bJh3tBmsQ+joqWguWK9BhNRbct86r3SCOG3aw+NM8mY4eLvNXNwfN6saA== X-Received: by 2002:a50:fe06:: with SMTP id f6mr8573867edt.125.1590263540260; Sat, 23 May 2020 12:52:20 -0700 (PDT) Received: from powell.devork.be (2a02-8388-8480-1180-4c18-fc69-8d8c-22b5.cable.dynamic.v6.surfer.at. [2a02:8388:8480:1180:4c18:fc69:8d8c:22b5]) by smtp.gmail.com with ESMTPSA id v16sm11220512ejq.74.2020.05.23.12.52.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2020 12:52:19 -0700 (PDT) Received: (nullmailer pid 80526 invoked by uid 1000); Sat, 23 May 2020 19:52:18 -0000 From: Floris Bruynooghe To: Daniel Kahn Gillmor , notmuch@notmuchmail.org Subject: Re: python-cffi and ruby test suites fail in out-of-tree builds In-Reply-To: <87h7w8iwod.fsf@fifthhorseman.net> References: <87h7w8iwod.fsf@fifthhorseman.net> Date: Sat, 23 May 2020 21:52:18 +0200 Message-ID: <87d06usa31.fsf@powell.devork.be> MIME-Version: 1.0 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: notmuch-bounces@notmuchmail.org Sender: "notmuch" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=gmail.com header.s=20161025 header.b=b/Dx/kK4; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 50.126.95.6 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: -0.01 X-TUID: LS5YBacKzSLf Hi, On Thu 21 May 2020 at 21:29 -0400, Daniel Kahn Gillmor wrote: > Hey folks-- > > I just did a bit of testing and cleanup for out-of-tree builds (see the > minor patches that should have landed on the list in the last hour or > two). It probably is indeed the unfortunate case that copying the python source is currently the easiest. I had a quick look and it seemed like one'd have to dig into the cffi setuptools support to make this work and I'm not sure how successful that would be, but I admit I didn't feel like trying. > For me, "make check" in an out-of-tree build works fine now, with the > exception of T391-python-cffi.sh and T395-ruby.sh. I checked out the python one, and maybe that's not too hard. The following patch made this work for both in tree and out of tree (on top of your other patch): modified test/T391-python-cffi.sh @@ -8,7 +8,7 @@ fi test_begin_subtest "python cffi tests" -pytest_dir=$NOTMUCH_SRCDIR/bindings/python-cffi/build/stage +pytest_dir=$NOTMUCH_BUILDDIR/bindings/python-cffi/build/stage printf "[pytest]\nminversion = 3.0\naddopts = -ra\n" > $pytest_dir/pytest.ini test_expect_success "(cd $pytest_dir && ${NOTMUCH_PYTHON} -m pytest --log-file=$TMP_DIRECTORY/test.output)" test_done Hope that's helpful. Cheers, Floris