unofficial mirror of notmuch@notmuchmail.org
 help / color / Atom feed
* python-cffi and ruby test suites fail in out-of-tree builds
@ 2020-05-22  1:29 Daniel Kahn Gillmor
  2020-05-23 19:52 ` Floris Bruynooghe
  2020-05-26 17:06 ` [PATCH] tests/ruby: Ensure that test works for " Daniel Kahn Gillmor
  0 siblings, 2 replies; 7+ messages in thread
From: Daniel Kahn Gillmor @ 2020-05-22  1:29 UTC (permalink / raw)
  To: notmuch


[-- Attachment #1.1: Type: text/plain, Size: 714 bytes --]

Hey folks--

I just did a bit of testing and cleanup for out-of-tree builds (see the
minor patches that should have landed on the list in the last hour or
two).

For me, "make check" in an out-of-tree build works fine now, with the
exception of T391-python-cffi.sh and T395-ruby.sh.

I'm afraid i don't know enough about either python or ruby to see the
obvious fix for these builds, but i do note that they're the only builds
which depend on copying their source into the out-of-tree location
(assuming no one proposes an improvement for
id:20200522010359.715688-1-dkg@fifthhorseman.net).

Just thought i'd flag this as an outstanding problem that hopefully
someone clever feels like digging into.

        --dkg

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: python-cffi and ruby test suites fail in out-of-tree builds
  2020-05-22  1:29 python-cffi and ruby test suites fail in out-of-tree builds Daniel Kahn Gillmor
@ 2020-05-23 19:52 ` Floris Bruynooghe
  2020-05-26 17:08   ` Daniel Kahn Gillmor
  2020-05-30 15:48   ` David Bremner
  2020-05-26 17:06 ` [PATCH] tests/ruby: Ensure that test works for " Daniel Kahn Gillmor
  1 sibling, 2 replies; 7+ messages in thread
From: Floris Bruynooghe @ 2020-05-23 19:52 UTC (permalink / raw)
  To: Daniel Kahn Gillmor, notmuch

Hi,

On Thu 21 May 2020 at 21:29 -0400, Daniel Kahn Gillmor wrote:

> Hey folks--
>
> I just did a bit of testing and cleanup for out-of-tree builds (see the
> minor patches that should have landed on the list in the last hour or
> two).

It probably is indeed the unfortunate case that copying the python
source is currently the easiest.  I had a quick look and it seemed like
one'd have to dig into the cffi setuptools support to make this work and
I'm not sure how successful that would be, but I admit I didn't feel
like trying.

> For me, "make check" in an out-of-tree build works fine now, with the
> exception of T391-python-cffi.sh and T395-ruby.sh.

I checked out the python one, and maybe that's not too hard.  The
following patch made this work for both in tree and out of tree (on top
of your other patch):

modified   test/T391-python-cffi.sh
@@ -8,7 +8,7 @@ fi
 
 
 test_begin_subtest "python cffi tests"
-pytest_dir=$NOTMUCH_SRCDIR/bindings/python-cffi/build/stage
+pytest_dir=$NOTMUCH_BUILDDIR/bindings/python-cffi/build/stage
 printf "[pytest]\nminversion = 3.0\naddopts = -ra\n" > $pytest_dir/pytest.ini
 test_expect_success "(cd $pytest_dir && ${NOTMUCH_PYTHON} -m pytest --log-file=$TMP_DIRECTORY/test.output)"
 test_done



Hope that's helpful.

Cheers,
Floris

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] tests/ruby: Ensure that test works for out-of-tree builds
  2020-05-22  1:29 python-cffi and ruby test suites fail in out-of-tree builds Daniel Kahn Gillmor
  2020-05-23 19:52 ` Floris Bruynooghe
@ 2020-05-26 17:06 ` Daniel Kahn Gillmor
  2020-05-26 17:07   ` Daniel Kahn Gillmor
  2020-05-31 19:16   ` David Bremner
  1 sibling, 2 replies; 7+ messages in thread
From: Daniel Kahn Gillmor @ 2020-05-26 17:06 UTC (permalink / raw)
  To: Notmuch Mail

---
 test/test-lib.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/test-lib.sh b/test/test-lib.sh
index 792b1cb9..78a90862 100644
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -1081,7 +1081,7 @@ test_python() {
 }
 
 test_ruby() {
-    MAIL_DIR=$MAIL_DIR $NOTMUCH_RUBY -I $NOTMUCH_SRCDIR/bindings/ruby> OUTPUT
+    MAIL_DIR=$MAIL_DIR $NOTMUCH_RUBY -I "$NOTMUCH_BUILDDIR/bindings/ruby"> OUTPUT
 }
 
 test_C () {
-- 
2.26.2

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] tests/ruby: Ensure that test works for out-of-tree builds
  2020-05-26 17:06 ` [PATCH] tests/ruby: Ensure that test works for " Daniel Kahn Gillmor
@ 2020-05-26 17:07   ` Daniel Kahn Gillmor
  2020-05-31 19:16   ` David Bremner
  1 sibling, 0 replies; 7+ messages in thread
From: Daniel Kahn Gillmor @ 2020-05-26 17:07 UTC (permalink / raw)
  To: Notmuch Mail

On Tue 2020-05-26 13:06:02 -0400, Daniel Kahn Gillmor wrote:
> ---
>  test/test-lib.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/test-lib.sh b/test/test-lib.sh
> index 792b1cb9..78a90862 100644
> --- a/test/test-lib.sh
> +++ b/test/test-lib.sh
> @@ -1081,7 +1081,7 @@ test_python() {
>  }
>  
>  test_ruby() {
> -    MAIL_DIR=$MAIL_DIR $NOTMUCH_RUBY -I $NOTMUCH_SRCDIR/bindings/ruby> OUTPUT
> +    MAIL_DIR=$MAIL_DIR $NOTMUCH_RUBY -I "$NOTMUCH_BUILDDIR/bindings/ruby"> OUTPUT
>  }
>  
>  test_C () {

I should note that i'm not a ruby developer, but this seems to be the
correct patch to solve the problem, similar to what Floris proposed to
fix the python-cffi test suite.

    --dkg

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: python-cffi and ruby test suites fail in out-of-tree builds
  2020-05-23 19:52 ` Floris Bruynooghe
@ 2020-05-26 17:08   ` Daniel Kahn Gillmor
  2020-05-30 15:48   ` David Bremner
  1 sibling, 0 replies; 7+ messages in thread
From: Daniel Kahn Gillmor @ 2020-05-26 17:08 UTC (permalink / raw)
  To: Floris Bruynooghe, notmuch


[-- Attachment #1.1: Type: text/plain, Size: 627 bytes --]

On Sat 2020-05-23 21:52:18 +0200, Floris Bruynooghe wrote:
> modified   test/T391-python-cffi.sh
> @@ -8,7 +8,7 @@ fi
>  
>  
>  test_begin_subtest "python cffi tests"
> -pytest_dir=$NOTMUCH_SRCDIR/bindings/python-cffi/build/stage
> +pytest_dir=$NOTMUCH_BUILDDIR/bindings/python-cffi/build/stage
>  printf "[pytest]\nminversion = 3.0\naddopts = -ra\n" > $pytest_dir/pytest.ini
>  test_expect_success "(cd $pytest_dir && ${NOTMUCH_PYTHON} -m pytest --log-file=$TMP_DIRECTORY/test.output)"
>  test_done

I've tested this and i can confirm that it works for both out-of-tree
and in-tree builds.  LGTM.

     --dkg

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: python-cffi and ruby test suites fail in out-of-tree builds
  2020-05-23 19:52 ` Floris Bruynooghe
  2020-05-26 17:08   ` Daniel Kahn Gillmor
@ 2020-05-30 15:48   ` David Bremner
  1 sibling, 0 replies; 7+ messages in thread
From: David Bremner @ 2020-05-30 15:48 UTC (permalink / raw)
  To: Floris Bruynooghe, Daniel Kahn Gillmor, notmuch

Floris Bruynooghe <flub@devork.be> writes:
>
> I checked out the python one, and maybe that's not too hard.  The
> following patch made this work for both in tree and out of tree (on top
> of your other patch):
>
> modified   test/T391-python-cffi.sh
> @@ -8,7 +8,7 @@ fi
>  
>  
>  test_begin_subtest "python cffi tests"
> -pytest_dir=$NOTMUCH_SRCDIR/bindings/python-cffi/build/stage
> +pytest_dir=$NOTMUCH_BUILDDIR/bindings/python-cffi/build/stage
>  printf "[pytest]\nminversion = 3.0\naddopts = -ra\n" > $pytest_dir/pytest.ini
>  test_expect_success "(cd $pytest_dir && ${NOTMUCH_PYTHON} -m pytest --log-file=$TMP_DIRECTORY/test.output)"
>  test_done
>

I smooshed this into id:20200522010359.715688-1-dkg@fifthhorseman.net
and pushed to master.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] tests/ruby: Ensure that test works for out-of-tree builds
  2020-05-26 17:06 ` [PATCH] tests/ruby: Ensure that test works for " Daniel Kahn Gillmor
  2020-05-26 17:07   ` Daniel Kahn Gillmor
@ 2020-05-31 19:16   ` David Bremner
  1 sibling, 0 replies; 7+ messages in thread
From: David Bremner @ 2020-05-31 19:16 UTC (permalink / raw)
  To: Daniel Kahn Gillmor, Notmuch Mail

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> ---
>  test/test-lib.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/test-lib.sh b/test/test-lib.sh
> index 792b1cb9..78a90862 100644
> --- a/test/test-lib.sh
> +++ b/test/test-lib.sh
> @@ -1081,7 +1081,7 @@ test_python() {
>  }
>  
>  test_ruby() {
> -    MAIL_DIR=$MAIL_DIR $NOTMUCH_RUBY -I $NOTMUCH_SRCDIR/bindings/ruby> OUTPUT
> +    MAIL_DIR=$MAIL_DIR $NOTMUCH_RUBY -I "$NOTMUCH_BUILDDIR/bindings/ruby"> OUTPUT
>  }
>  
>  test_C () {
> -- 

pushed to master

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-22  1:29 python-cffi and ruby test suites fail in out-of-tree builds Daniel Kahn Gillmor
2020-05-23 19:52 ` Floris Bruynooghe
2020-05-26 17:08   ` Daniel Kahn Gillmor
2020-05-30 15:48   ` David Bremner
2020-05-26 17:06 ` [PATCH] tests/ruby: Ensure that test works for " Daniel Kahn Gillmor
2020-05-26 17:07   ` Daniel Kahn Gillmor
2020-05-31 19:16   ` David Bremner

unofficial mirror of notmuch@notmuchmail.org

Archives are clonable:
	git clone --mirror https://yhetil.org/notmuch/0 notmuch/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 notmuch notmuch/ https://yhetil.org/notmuch \
		notmuch@notmuchmail.org
	public-inbox-index notmuch

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.mail.notmuch.general
	nntp://news.gmane.io/gmane.mail.notmuch.general


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git