From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id pr9KLVZKKF+TcAAA0tVLHw (envelope-from ) for ; Mon, 03 Aug 2020 17:33:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id eKmmKFZKKF/rbAAA1q6Kng (envelope-from ) for ; Mon, 03 Aug 2020 17:33:10 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 674089400BB for ; Mon, 3 Aug 2020 17:33:09 +0000 (UTC) Received: from [144.217.243.247] (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 86F5E29A81; Mon, 3 Aug 2020 13:33:01 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 4107C28DE9 for ; Mon, 3 Aug 2020 13:32:59 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 5E8665FA66; Mon, 3 Aug 2020 13:32:57 -0400 (EDT) Received: (nullmailer pid 3297836 invoked by uid 1000); Mon, 03 Aug 2020 17:32:56 -0000 From: David Bremner To: Jonas Bernoulli , Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH 00/23] A great number of cosmetic changes In-Reply-To: <87lfiyt7mx.fsf@bernoul.li> References: <20200726165818.400-1-jonas@bernoul.li> <87lfiyt7mx.fsf@bernoul.li> Date: Mon, 03 Aug 2020 14:32:56 -0300 Message-ID: <87d047bpo7.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: NDOPNQM2DVGIRRR7SSIMF6APUIUBILVN X-Message-ID-Hash: NDOPNQM2DVGIRRR7SSIMF6APUIUBILVN X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: 0.53 X-TUID: DRNf+yiBEGzy Jonas Bernoulli writes: > Tomi Ollila writes: > >> Series looks good to me (as far as I can tell). That one comment >> indentation in id:20200726165818.400-4-jonas@bernoul.li is what popped up >> in my review (I did review only diff patch, and don't know how that >> actually look -- like in those spaces after do in my previous reply, those >> look good to me now) > > Thanks for the review. Should I send a v2 now or wait a bit to see if > someone else spots any issues? I think it's probably safe to send v2 now. d