unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / Atom feed
* [PATCH 1/2] lib/open: remove incorrect unused attribute
@ 2021-02-15  2:31 David Bremner
  2021-02-15  2:31 ` [PATCH 2/2] lib: use a stricter unused macro David Bremner
  0 siblings, 1 reply; 4+ messages in thread
From: David Bremner @ 2021-02-15  2:31 UTC (permalink / raw)
  To: notmuch; +Cc: David Bremner

With the current unused macro in lib/notmuch-private.h this seems
harmless, but is misleading, since the parameter is in fact used.
---
 lib/open.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/open.cc b/lib/open.cc
index b4637ec5..3b86065b 100644
--- a/lib/open.cc
+++ b/lib/open.cc
@@ -186,7 +186,7 @@ notmuch_status_t
 notmuch_database_open_with_config (const char *database_path,
 				   notmuch_database_mode_t mode,
 				   const char *config_path,
-				   unused(const char *profile),
+				   const char *profile,
 				   notmuch_database_t **database,
 				   char **status_string)
 {
-- 
2.30.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] lib: use a stricter unused macro
  2021-02-15  2:31 [PATCH 1/2] lib/open: remove incorrect unused attribute David Bremner
@ 2021-02-15  2:31 ` David Bremner
  2021-02-15 20:22   ` Tomi Ollila
  0 siblings, 1 reply; 4+ messages in thread
From: David Bremner @ 2021-02-15  2:31 UTC (permalink / raw)
  To: notmuch; +Cc: David Bremner

This would have caught bugs like the one corrected in the previous commit.
---
 lib/notmuch-private.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h
index 2fbf7ab9..2f5ccd6a 100644
--- a/lib/notmuch-private.h
+++ b/lib/notmuch-private.h
@@ -76,7 +76,7 @@ NOTMUCH_BEGIN_DECLS
 #define NOTMUCH_CLEAR_BIT(valp,  bit) \
     (_NOTMUCH_VALID_BIT (bit) ? (*(valp) &= ~(1ull << (bit))) : *(valp))
 
-#define unused(x) x __attribute__ ((unused))
+#define unused(x) x ## _unused __attribute__ ((unused))
 
 /* Thanks to Andrew Tridgell's (SAMBA's) talloc for this definition of
  * unlikely. The talloc source code comes to us via the GNU LGPL v. 3.
-- 
2.30.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] lib: use a stricter unused macro
  2021-02-15  2:31 ` [PATCH 2/2] lib: use a stricter unused macro David Bremner
@ 2021-02-15 20:22   ` Tomi Ollila
  2021-02-15 20:42     ` David Bremner
  0 siblings, 1 reply; 4+ messages in thread
From: Tomi Ollila @ 2021-02-15 20:22 UTC (permalink / raw)
  To: David Bremner, notmuch; +Cc: David Bremner

On Sun, Feb 14 2021, David Bremner wrote:

> This would have caught bugs like the one corrected in the previous
> commit.

Series LGTM.

Tomi

> ---
>  lib/notmuch-private.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h
> index 2fbf7ab9..2f5ccd6a 100644
> --- a/lib/notmuch-private.h
> +++ b/lib/notmuch-private.h
> @@ -76,7 +76,7 @@ NOTMUCH_BEGIN_DECLS
>  #define NOTMUCH_CLEAR_BIT(valp,  bit) \
>      (_NOTMUCH_VALID_BIT (bit) ? (*(valp) &= ~(1ull << (bit))) : *(valp))
>  
> -#define unused(x) x __attribute__ ((unused))
> +#define unused(x) x ## _unused __attribute__ ((unused))

looks familiar ;D

>  
>  /* Thanks to Andrew Tridgell's (SAMBA's) talloc for this definition of
>   * unlikely. The talloc source code comes to us via the GNU LGPL v. 3.
> -- 
> 2.30.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] lib: use a stricter unused macro
  2021-02-15 20:22   ` Tomi Ollila
@ 2021-02-15 20:42     ` David Bremner
  0 siblings, 0 replies; 4+ messages in thread
From: David Bremner @ 2021-02-15 20:42 UTC (permalink / raw)
  To: Tomi Ollila, notmuch

Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Sun, Feb 14 2021, David Bremner wrote:
>
>> This would have caught bugs like the one corrected in the previous
>> commit.
>
> Series LGTM.
>
> Tomi

Applied to master

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-02-15 20:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-15  2:31 [PATCH 1/2] lib/open: remove incorrect unused attribute David Bremner
2021-02-15  2:31 ` [PATCH 2/2] lib: use a stricter unused macro David Bremner
2021-02-15 20:22   ` Tomi Ollila
2021-02-15 20:42     ` David Bremner

unofficial mirror of notmuch@notmuchmail.org

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/notmuch/0 notmuch/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 notmuch notmuch/ https://yhetil.org/notmuch \
		notmuch@notmuchmail.org
	public-inbox-index notmuch

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.mail.notmuch.general
	nntp://news.gmane.io/gmane.mail.notmuch.general


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git