From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YNVlD0xa9WDABwAAgWs5BA (envelope-from ) for ; Mon, 19 Jul 2021 12:56:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 6Ko0C0xa9WCDGQAAbx9fmQ (envelope-from ) for ; Mon, 19 Jul 2021 10:56:12 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DB8DE120EB for ; Mon, 19 Jul 2021 12:56:11 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id BA5CB290A3; Mon, 19 Jul 2021 06:56:07 -0400 (EDT) X-Greylist: delayed 370 seconds by postgrey-1.36 at nmbug; Mon, 19 Jul 2021 06:56:03 EDT Received: from mail.hostpark.net (mail.hostpark.net [212.243.197.30]) by mail.notmuchmail.org (Postfix) with ESMTPS id 1B6762909F for ; Mon, 19 Jul 2021 06:56:02 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 4A4B9163CB; Mon, 19 Jul 2021 12:49:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received; s=sel2011a; t=1626691789; bh=DKHggchAIn0sNe2Chxqw3YRo 3pVoNySXWIm5ymrH0bs=; b=qONhFqGym7z7i0PhTeXwyM3MhfOBLaLhhYhQah+T xI4CB8KM9Szgv6I2lG6LuN4sDQjS2oGhaix5gYEQw0ggjNA394xewynKTE/4ML+r KrwMOSWoyfTTdnVglfkXSs1uap5jFe3iq5ypNu+XLlck/vyWuiK55A7LngS8dilw oxs= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id deku8glGLJeB; Mon, 19 Jul 2021 12:49:49 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 04F1016454; Mon, 19 Jul 2021 12:49:48 +0200 (CEST) From: Jonas Bernoulli To: David Bremner , notmuch@notmuchmail.org Cc: David Bremner Subject: Re: [PATCH] emacs: remove useless lexically bound variable In-Reply-To: <20210707015108.65309-1-david@tethera.net> References: <20210707015108.65309-1-david@tethera.net> Date: Mon, 19 Jul 2021 12:49:48 +0200 Message-ID: <87czre60j7.fsf@bernoul.li> MIME-Version: 1.0 Message-ID-Hash: K4U75E33Z5MG3YBMRPK5VAPPFKWVQLK7 X-Message-ID-Hash: K4U75E33Z5MG3YBMRPK5VAPPFKWVQLK7 X-MailFrom: jonas@bernoul.li X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626692172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=NIRhyZItRqAnZ/jUMwWFE/AKcv2mqmzm9ZtEK2dPW28=; b=QlMLVws52vH2fjdZwWwOQQ5KAxXRCpgi397hb16f8UKEeHC+kcTi4q2UT/wUjtXusf2YPT K5XqcHocd35HBUplLdQdFRx+sLjXk0isqosDDeRwN9FUJELcjEfnPQqf9+qq2YiThWBxlo AW+aEQhjVcAOqZ6Q4q/8kWH9wfrV2F87G0kuLaIQK0cyEHOWqrRzsIGQ28RBVJ2YxpFZLS eshldAOoCNrPAM2VB9A/H8ZHTK4ZLZ8EeHJf4NZQwWfaVsXuEH5B0sBwK1qGuPufckbXOt eWnabwHJVCjM1v+BDtSrg9Wfg/1vO30noehnZgfjb72j/rwWTKEV6P14RU2Pwg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626692172; a=rsa-sha256; cv=none; b=hCpZubBMNudC215vgVZX5bG4iTWIowfsO3W8uZOsOJSTBJH8RyT8SDPrLZr7YT78Fq55vg 25a4j717dBSZfnecpCM2FQXUJr/fuOBFp8o+H9hyy8OQc6qhVV7Tw0BYTJJCib8JZbqVB1 DFatoSdZAv1fSHjTVi6d/QdY2AFVa3iMEmZXINiu9SQrgs2W4v3lVJQzqWIn9pO6TNJIHZ +f+OqCOZgw4IL5Wdmx4hWZoUYX8SmqtolmANRcQ+y41+xnshx46HGjaCGtllhYuJDBqiTd Mp/F3mN5EDbyAg8ccoISfzKj0obiK5Ydtg/K0yFVpvAcgQ1noCehU3ExZj9nMw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=bernoul.li header.s=sel2011a header.b=qONhFqGy; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.08 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=bernoul.li header.s=sel2011a header.b=qONhFqGy; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: DB8DE120EB X-Spam-Score: -1.08 X-Migadu-Scanner: scn0.migadu.com X-TUID: /m1OS4ILnCmk +1 (I was gonna suggest the same change.) David Bremner writes: > A let binding without a value is just an obfuscated way of saying > nil, especially if you are not going to mutate the variable. > --- > emacs/notmuch-tree.el | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el > index b288c05d..eb7ea941 100644 > --- a/emacs/notmuch-tree.el > +++ b/emacs/notmuch-tree.el > @@ -1001,10 +1001,9 @@ message together with all its descendents." > > (defun notmuch-tree-insert-forest-thread (forest-thread) > "Insert a single complete thread." > - (let (tree-status) > - ;; Reset at the start of each main thread. > - (setq notmuch-tree-previous-subject nil) > - (notmuch-tree-insert-thread forest-thread 0 tree-status))) > + ;; Reset at the start of each main thread. > + (setq notmuch-tree-previous-subject nil) > + (notmuch-tree-insert-thread forest-thread 0 nil)) > > (defun notmuch-tree-insert-forest (forest) > "Insert a forest of threads. > -- > 2.30.2 > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org