From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +P4IFiczCGGePQEAgWs5BA (envelope-from ) for ; Mon, 02 Aug 2021 20:02:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UJI0ESczCGHkfQAA1q6Kng (envelope-from ) for ; Mon, 02 Aug 2021 18:02:15 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 757B1AC88 for ; Mon, 2 Aug 2021 20:02:14 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id BCC152C066; Mon, 2 Aug 2021 14:02:10 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 081332C04E for ; Mon, 2 Aug 2021 14:02:08 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id E0E475FD5C; Mon, 2 Aug 2021 14:02:07 -0400 (EDT) Received: (nullmailer pid 3284446 invoked by uid 1000); Mon, 02 Aug 2021 18:02:06 -0000 From: David Bremner To: Milton Vandersloot , "notmuch@notmuchmail.org" Subject: Re: Mark Emacs as prerequisite for tests which require it In-Reply-To: References: Date: Mon, 02 Aug 2021 15:02:06 -0300 Message-ID: <87czqvzpwh.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: YJ45QNTJD43H52AXGA542CLWMGZUIKHL X-Message-ID-Hash: YJ45QNTJD43H52AXGA542CLWMGZUIKHL X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1627927335; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=z6TgngKXJimjEIWl6JMxs6C6RGXOOLEYo+vTRgHRB5k=; b=JNGFSAJDuKA2o57aa8/xjOvxG3UNTVI0nwdWqVaU6TagNjO6mXsNcErI3i8iNAZgi2Gpbq 1r18Byi7gDdZnMwSfwMrxUua76fMHvte0avdBi8Bjt2CrXwSkAxOsGCKwMLlcHVnrprN9O ZVY7jY3F99OLzV7zMSv6AYPiyFxR4HHm2uddN40aHq2BH5vZwRMUqSUr03gVSCYBeJxuKb KHcjdXQCWJDO5FhrjieUu+R4LAxyRSBfF3V+b2KGhuRMmXN7AtfVzLbpr6uIEqUtYEFN75 CsuRZJpf+Z7DJH2Md/nSDKEt6k8MYvy3Ydjbf49evopVIelGlCe9SQKs5rWGag== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1627927335; a=rsa-sha256; cv=none; b=WEEPyMQEoVQX0OIgjnmw2Qv4CKEUhDt4sAu7IqwhX+naN6h7vi9Pu6ioEaWziraVBfblnw tIZPoNyMGOfodezCvXgbG/W4RQElubT7EJZDMli0OdclwSdpMUUxx9PzdgpEx2cp7N7wD9 AEVgiiZ4S72adBsZGaSfAPuXf1ajKgIy46w/fkTwTkgHTpRguhiwH6wLdYAin8pmZwecV1 mC3dsP982ZribXHajWRXNcqEMbmVoj3n2cbJogWLjVT+ADvxznz4BAW+4Q8Y7OCjM5fY6Y sohPgmOlhXbzBbXeJN/4dfoUfupiwmN5kFquHF89egBPfd4kSwb8k9jDaaWYNw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.47 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 757B1AC88 X-Spam-Score: -0.47 X-Migadu-Scanner: scn1.migadu.com X-TUID: LLFeqU7iQUUS Milton Vandersloot writes: > Dear notmuch developers > > The notmuch test suite depends on some external dependencies to finish successfully (i.e. no failures but maybe some skips), one of them being Emacs. > As I had no Emacs installed, I discovered that some tests fail and do not state properly that Emacs is needed for them. > Below are small sed commands (was easier this way) which put the "test_require_external_prereq emacs" to the missing places. > > For some tests (those which test Emacs capabilities) it is clear that Emacs is a necessity, some tests in particular the crypto tests (T350, T355, T357) do require Emacs only for generating a initial mail to index/test on. Here it would in my opinion be better to find an alternative way of producing that e-mail so these tests can be run without Emacs (That would reduce the long list of test names below tremendously). A promising approach would be using the same idea as the last tests in T357-index-decryption.sh, they use "add_email_corpus crypto" for (what seems to me) populating the mail archive. I think this is now handled by the commits following cd9ec20a49, which will be in the next release of notmuch.