From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ICUHO2vnZmHcRwEAgWs5BA (envelope-from ) for ; Wed, 13 Oct 2021 16:04:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id uJqtNmvnZmGrSgAA1q6Kng (envelope-from ) for ; Wed, 13 Oct 2021 14:04:27 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AF271233EA for ; Wed, 13 Oct 2021 16:04:27 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id B28BE2C1AA; Wed, 13 Oct 2021 10:04:25 -0400 (EDT) Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by mail.notmuchmail.org (Postfix) with ESMTPS id DA3522C19F for ; Wed, 13 Oct 2021 10:04:22 -0400 (EDT) Received: by mail-lf1-x12c.google.com with SMTP id y26so12338095lfa.11 for ; Wed, 13 Oct 2021 07:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nikula-org.20210112.gappssmtp.com; s=20210112; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=azTkVuITDUP/KWWqLFs76s56f2dvT7TMjEP4RSl/b3I=; b=6cnxut0UMX+jF+YzNuSIa2BI3gbIyGffPj0TrhLoVGImxMHq+zxFegKymJC+v4bxIO F2pMAV5pZVBjHj1BvjHgFXaExArLeiVJEWmtpWOjVfi8/n2A1gdPx2Y8o46IMTsBImx/ bpb44LRwJJKJBYMS8Ennzxp3pdJZVZQ+DCRhRi6wbHznpSFW6kgJB7BU6bTe1wh8nw6u pYq8Xwy5aDNUpGwgCTvbR5l9Fu1UIk/S5p2oQgAM5YiXnJjfAw7ag2cE8QGMjGUhEaCI JBMlvH1HEWYR2PuKY7dQROXfeMVKHP4NjKXF4XJ9bQhAwdEx9DPbaVpxwvr6kXfLMlJw NAJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=azTkVuITDUP/KWWqLFs76s56f2dvT7TMjEP4RSl/b3I=; b=cUQYHi6iOqSB1Exoq6/knMv1iuioDdDSt1a6F7pz3uDdNziIFGtSgsW51VXqSLRUkN xkxATwSyW3vona/LBowaxCoEG9gq2BqXc4v7tpa3/4gvaUexer1mmRSng16kXAsXtVtu EsVxf0uoL1v+Z4ZXvhMR8ZyDG/YqH6H6JdRJO8XqsZucZ2KJ4JNe55QVLGyGQLEJNo4Y wEC8FvkINFNwD1zwqo+QaPN9uMGu0uyRQJ5wqkeIKVW2PzjSPOuSyze4V2WW8xHieWsN 7VhMHuw93h8pHh6KaoYbFyWEnmVPG/e3wh9rWJDskruxx1URlhTNP0V86GcWH+DjkbOh VAfg== X-Gm-Message-State: AOAM530q4xAfvNmew6E63GynFYNMnA8SBRk1XA+Je5FBamSdg2++Oldx +5PvE9tQerJ+vflgSh7SJ+l0dYikifTxKszDF3w= X-Google-Smtp-Source: ABdhPJyZ57YSJFdnrutoflyY5/pCjh+HPdrkG+Cpw5HnIcPaefJb/ROQ58jvskL3qDktK6ojHprFRg== X-Received: by 2002:a05:6512:20d:: with SMTP id a13mr18150019lfo.394.1634133860429; Wed, 13 Oct 2021 07:04:20 -0700 (PDT) Received: from localhost (87-95-50-104.bb.dnainternet.fi. [87.95.50.104]) by smtp.gmail.com with ESMTPSA id s13sm1456610lfp.70.2021.10.13.07.04.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 07:04:19 -0700 (PDT) From: Jani Nikula To: Tomi Ollila , David Bremner , notmuch@notmuchmail.org Subject: Re: [RFC 2/5] lib: remove enum names from typedefs In-Reply-To: References: <20211012185127.198348-1-jani@nikula.org> <20211012185127.198348-3-jani@nikula.org> <87y26xkqql.fsf@tethera.net> Date: Wed, 13 Oct 2021 17:04:18 +0300 Message-ID: <87czo910nx.fsf@nikula.org> MIME-Version: 1.0 Message-ID-Hash: 2UVAUQOC2JU4EDQE225MQY2WBHG5NPRN X-Message-ID-Hash: 2UVAUQOC2JU4EDQE225MQY2WBHG5NPRN X-MailFrom: jani@nikula.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634133867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=JcOb0nHvU3hEIaZc0dfly3asuXWcoCWl6d7bwD6iow0=; b=foQW6mdKoFtyNFxblOrpbxy3uTG0MBlA5J7V1vwUpLQJrvNqTHoD6bNItDC/sxZQf+3Nng C52wLPvy1Uw2uNrs3j9yWGusR/isK4V4BflXYL0pYP+fxiLyNLROq6e5HlIgFOR12Jt9xQ XlRukVsJwWQLbJEaljeb2mueNRJbSngUrEkQoLDPWpcFGgLkcfnR7A/w1u2jvwaf+FEflB 9/axx+3cUK+IUw0bvwKr9eCmdk4/AtkuOiAucYeIfGxspTGJ9c8LEyoHtYU1R1f2u7Twu6 5Hp2huy4r5KGwusYqkQettUZTrP2DbzqE0EMQE1obs0Ar/1AC+mBMpMikgQh2w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634133867; a=rsa-sha256; cv=none; b=pzyqztUttkrObxzsML8V1bTLqNl7L1WM/LknopX3E4O8H1RES2WjcQVrnFo9woJZ+u4iJ/ tuNdQ4qoDPqqIM7NrDOZfIjYZYcIqUwSDiuiGo9LXXYOQAC03AzIBdH7elk6/+JpzvSGID 0E6sWyeOysMFodq3/hyw3dQp2sAtaWr0axXO93uTY2vEt27imHL0c+C1zVrWpmlfbnN02D akLfaGc6qqWCOOJ/ayxXJ8n9+pC9bNiGKj4L1XoHkpne7yWumymi6q158pUOEiZH4HHAbC CvqRJAcMLxF4jmaCzkDZk8eqc+1BV8KAmA6/gNVIw/1bmDF+/KHhNJ2tqwV8/g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=nikula-org.20210112.gappssmtp.com header.s=20210112 header.b=6cnxut0U; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.04 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=nikula-org.20210112.gappssmtp.com header.s=20210112 header.b=6cnxut0U; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: AF271233EA X-Spam-Score: -1.04 X-Migadu-Scanner: scn0.migadu.com X-TUID: z+7gr/1ls2MV On Wed, 13 Oct 2021, Tomi Ollila wrote: > On Wed, Oct 13 2021, David Bremner wrote: > >> Jani Nikula writes: >> >>> Given the named enum typedef: >>> >>> typedef enum _name_t { ... } name_t; >>> >>> Hawkmoth uses _name_t as the name for documentation. Typedef the >>> anonymous enum: >>> >>> typedef enum { ... } name_t; >>> >>> instead to use name_t. We don't really need the enum names for >>> anything, and not all of the enum typedefs have them anyway. >>> --- >> I guess that change would be fine independent of the rest? > > I had the same thought. Added more typedef enums outside of notmuch.h, removed hawkmoth references, and resent separately. BR, Jani.