From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MLQPGyym6GHBfAAAgWs5BA (envelope-from ) for ; Thu, 20 Jan 2022 01:00:44 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id V/a2Eyym6GFzBAEAG6o9tA (envelope-from ) for ; Thu, 20 Jan 2022 01:00:44 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B1F2EE77C for ; Thu, 20 Jan 2022 01:00:43 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 0DB645F6DA; Thu, 20 Jan 2022 00:00:39 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 368AE5F527 for ; Thu, 20 Jan 2022 00:00:36 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 25F855FC01; Wed, 19 Jan 2022 19:00:35 -0500 (EST) Received: (nullmailer pid 3437781 invoked by uid 1000); Thu, 20 Jan 2022 00:00:33 -0000 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH] CLI: print extra headers only for non-replies In-Reply-To: References: <20220119011451.3079127-1-david@tethera.net> <20220119013400.3155683-1-david@tethera.net> Date: Wed, 19 Jan 2022 20:00:33 -0400 Message-ID: <87czknuvha.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: WANCXORLBTAENE6CHZ2IZDDHUJUKRHBR X-Message-ID-Hash: WANCXORLBTAENE6CHZ2IZDDHUJUKRHBR X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642636843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=oLv16XhHJ3yCaB6Sz665uYm6iNLUPwDjHTrzHI/tBNc=; b=e6YY6r2c13Fk7PSRlrJYelgYd/yQ6qRRm8fmw7nTW0dFq3tuHmDnfPAVlkC4OBuy1BpTFU UeFuakP2knQSjnKm1D1Tw1BGrp1+azJ4CRB+jfRldZQvXYSU2Z8w3aR8BN2kqJe7tYl3ly GegU/7MBpdCQ25tIzGw8vxJsj2iwwgKUDqsFZp7XzGqAGoWCEpdbGbLS5b7cUZUXqT90Rd zqEFDqafieBeYPi3OGRGIuhKxne05QJ6EhtjK8E+eUSIup/nOEV7HsT/DtehY2otXobP7t xBN/eVyb3oEaZCC0ZjtOuNBAe979P9rZNoee8riQCmQyba7w2pVHqMZPC3ELTw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642636843; a=rsa-sha256; cv=none; b=i+IQ+SbJsu8MQNcgOkl9xLGfja1awPajufPIDy6Jlx5TcqXeCfERPxgadCARoUavnAo8Z9 JDfyp/boWCNb9VqkoEuODURVwZFgtK1+uFv0naDgNTr7IU1KsKwbC8Cb8YwbPD3sFJK6hp 0eMEtu7s/bEjLnG1iPY/2IvabWdubBJWwSuR88kORAHSTbf6MjpslRZXmx6qMPQWqPADJd IU0VKdVwk6kEd6a6wiBVAwKS08R2jS81h1zLMl79LakqZ2TT0SPNJM9sUSkcN8tUh7dhjO ieditMUu//5WQ/zUI0cKPpM/iY3vBG8xgomK36gzH7UaWfq8WK4UIf6SElGK5w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.35 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: B1F2EE77C X-Spam-Score: -2.35 X-Migadu-Scanner: scn1.migadu.com X-TUID: z/fccigMs7ma Tomi Ollila writes: > On Tue, Jan 18 2022, David Bremner wrote: > >> If in the future we decide to output extra headers for replies, this >> should be controlled by a separate configuration option. >> --- >> notmuch-show.c | 3 ++- >> test/T310-emacs.sh | 1 - >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/notmuch-show.c b/notmuch-show.c >> index 136f4439..6a54d9c1 100644 >> --- a/notmuch-show.c >> +++ b/notmuch-show.c >> @@ -294,7 +294,8 @@ format_headers_sprinter (sprinter_t *sp, GMimeMessage *message, >> } >> >> /* Output extra headers the user has configured, if any */ >> - format_extra_headers_sprinter (sp, message); >> + if (! reply) >> + format_extra_headers_sprinter (sp, message); > > Looks simple enough for LGTM. > applied to master