[PATCH] emacs: fix dangling overlays in notmuch-search

[PATCH] emacs: fix dangling overlays in notmuch-search

[Matt Armstrong]

notmuch-search-insert-authors now sets the evaporate property on the
ellipsis overlays.  Emacs will delete them when the buffer contents
are zeroed out, which happens with `notmuch-refresh-buffer`.  This
prevents them from being collapsed to zero-width overlays in position
1.  See Emacs bug#58479.  An upcoming change in Emacs will make these
dangling overlays visible to the user.
---
 emacs/notmuch.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 26181758..6eef4af1 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -841,6 +841,7 @@ non-authors is found, assume that all of the authors match."
 	      overlay)
 	  (insert invisible-string)
 	  (setq overlay (make-overlay start (point)))
+	  (overlay-put overlay 'evaporate t)
 	  (overlay-put overlay 'invisible 'ellipsis)
 	  (overlay-put overlay 'isearch-open-invisible #'delete-overlay)))
       (insert padding))))
-- 
2.35.1

Re: [PATCH] emacs: fix dangling overlays in notmuch-search

[Matt Armstrong]

Matt Armstrong <matt@rfc20.org> writes:

> See Emacs bug#58479.  An upcoming change in Emacs will make these
> dangling overlays visible to the user.

It seems that the ellipsis overlays were shown due to a bug in Emacs,
but this patch is still a reasonable idea.  Otherwise, every time a
notmuch search buffer is refreshed (by pressing 'g') the overlays from
the previous run will collapse to zero-width overlays in position 1.
They're harmless there, but removing them is what 'evaporate is for.

Re: [PATCH] emacs: fix dangling overlays in notmuch-search

[David Bremner]

Matt Armstrong <matt@rfc20.org> writes:

> notmuch-search-insert-authors now sets the evaporate property on the
> ellipsis overlays.  Emacs will delete them when the buffer contents
> are zeroed out, which happens with `notmuch-refresh-buffer`.  This
> prevents them from being collapsed to zero-width overlays in position
> 1.  See Emacs bug#58479.  An upcoming change in Emacs will make these
> dangling overlays visible to the user.
> ---
applied to master

d