[PATCH] test/cli: Add known broken test for (missing) quoting in From

[PATCH] test/cli: Add known broken test for (missing) quoting in From

[David Bremner]

In [1], Jakub Wilk observes that the current behaviour is confusing
since it looks like there are two mailboxes in From, while in fact
there is only one.  It seems to me that notmuch should at least quote
the display-name part of a mailbox if it has "funny" characters in it,
and perhaps always quote it. Either way will require changing the
indexing code, since the structure is lost when writing the headers to
the database.

[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1021614
---
 test/T520-show.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/test/T520-show.sh b/test/T520-show.sh
index 6bcf109c..8121c3db 100755
--- a/test/T520-show.sh
+++ b/test/T520-show.sh
@@ -45,6 +45,12 @@ if [ "${NOTMUCH_HAVE_SFSEXP-0}" = "1" ]; then
 
 fi
 
+test_begin_subtest "quoting in From"
+test_subtest_known_broken
+add_message '[from]="=?UTF-8?Q?=3Cfoo=40example.org=3E=2C?= <bar@example.org>"'
+output=$(notmuch show id:${gen_msg_id}|grep From:)
+test_expect_equal "${output}" 'From: "<foo@example.org>," <bar@example.org>'
+
 add_email_corpus duplicate
 
 ID1=debian/2.6.1.dfsg-4-1-g87ea161@87ea161e851dfb1ea324af00e4ecfccc18875e15
-- 
2.43.0

Re: [PATCH] test/cli: Add known broken test for (missing) quoting in From

[David Bremner]

David Bremner <david@tethera.net> writes:

> In [1], Jakub Wilk observes that the current behaviour is confusing
> since it looks like there are two mailboxes in From, while in fact
> there is only one.  It seems to me that notmuch should at least quote
> the display-name part of a mailbox if it has "funny" characters in it,
> and perhaps always quote it. Either way will require changing the
> indexing code, since the structure is lost when writing the headers to
> the database.
>

applied to master.