From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id +83oJwAOomZpPgAA62LTzQ:P1 (envelope-from ) for ; Thu, 25 Jul 2024 08:34:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id +83oJwAOomZpPgAA62LTzQ (envelope-from ) for ; Thu, 25 Jul 2024 10:34:08 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=tethera.net header.s=2024 header.b=U0zoDPsh; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1721896448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=HdPlOTPACQ+8iQf7cl4e07YADrQP/NGPgDkymXGPVv0=; b=pU875fSFzXNsO+5SrJS+8oVWsEJB7myEH5Q1xBnWp6fSCLMv/anKJWt24kiq7ZZfi+i8oI JIizrFeu6E2i0KKL4cJj14Qjv0hxkHJzBPDot8vyNTtLvhxMvWYyeo3ozLG4BpB8wfkdKc HcIJ7l08AD1aE3oGoC6FPjJGLkTq7kkUhaUbMZJB0LyHFExI7QWr4RIb9RmBIS8m9XijCb WKgxX5GGZ6OwRK3iCfTS2tTVcA6vq0b5QDlpKij+xNX7sY0Q2ty+fSkEysmvIMWghYejkF zg8Bh6qgluG7KikYAk5CgpzOK77XFG9CVA+H/zjkJw71t2HLCY4q8RM81UkrFQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1721896448; a=rsa-sha256; cv=none; b=gXuJTNLMaNEgnC9r06E/jrGTvCBCvHcP80NeU8guJrh9+shojMkXmqY2nz6FyUPRbqDQLQ C9Qid3IQspCnZIAn/QbY5wchEy3wpm+jGcEJENBO4bxBOLiMO76XIV+hiBk2+IC+HP+sjW JcT9HknTidAH6ClurNA4x+kzftmrCMg7Z03GsdhSvVekr9DjrKBtyXSueRCx3wzADx2t/F 44BRV1iGx61i9BNrx6RcrwahT70zi0ssnC1XsslSaTHVg/k9BFKngdAPjhTkuayGsPr5W6 c9u3uy41nrt+KzwLyO4TlqT8VhwXluRC78y5tHIztOZeRIn6fi4QpopHwAJ1zA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=tethera.net header.s=2024 header.b=U0zoDPsh; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C83C278C96 for ; Thu, 25 Jul 2024 10:34:07 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 03DD05F4A5; Thu, 25 Jul 2024 08:33:59 +0000 (UTC) Received: from phubs.tethera.net (phubs.tethera.net [IPv6:2607:5300:60:3a9d::1]) by mail.notmuchmail.org (Postfix) with ESMTPS id 7CF785E50E for ; Thu, 25 Jul 2024 08:33:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tethera.net; i=@tethera.net; q=dns/txt; s=2024; t=1721896433; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=pZVHlw0/dS+nPJZLp4c10QbonLb7hjX7xEvqZPnefuE=; b=U0zoDPshcpHK5TdNKFBQDomumN1zNEJFtb/UjKf0i3gd0m3ZvaFLL+a84XOecrfFkpRLr Rju/MmN560HLZSmwq2LaYlv9ByJa7B7xJPMMxMjtW6M7w4dBEq0ZgijZg/VjjFYlUwju3ET VzLH85s+/N5aHw4bnMAz4oAe6+gpXH0Je8ZwEScSC1Oel3FpTkFiW3qo/r8rp+/DipPZhRf Ay7oACW9LUA0CJltMbOQ7e0hpFmn/4RNArXXoTyz98jRIA1KPkS+sqd5WlaRgT2ZxaR8Mht emrjorG6pQTJUdbHGVb1SpxGaHYeopI1WIIf2EmcVX1IQmCicyYkReU/HiIQ== Received: from tethera.net (unknown [210.110.131.58]) by phubs.tethera.net (Postfix) with ESMTPS id BD57A18006E; Thu, 25 Jul 2024 05:33:52 -0300 (ADT) Received: (nullmailer pid 210254 invoked by uid 1000); Thu, 25 Jul 2024 08:33:48 -0000 From: David Bremner To: Lars Kotthoff , notmuch@notmuchmail.org Subject: Re: [PATCH] config: allow custom separators in author lists In-Reply-To: <171985925199.1348.6214659455340451788.kukulkan@unkai> References: <171985925199.1348.6214659455340451788.kukulkan@unkai> Date: Thu, 25 Jul 2024 17:33:48 +0900 Message-ID: <87cyn1kh03.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: AMYFWAAXVSHE4XWENOL7SRC5GKP3K2R3 X-Message-ID-Hash: AMYFWAAXVSHE4XWENOL7SRC5GKP3K2R3 X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE X-Migadu-Spam-Score: 0.93 X-Spam-Score: 0.93 X-Migadu-Queue-Id: C83C278C96 X-Migadu-Scanner: mx11.migadu.com X-TUID: Mr5hSlto5BxC Lars Kotthoff writes: > Sorry, I dropped the ball on this -- here's the patch again with space/tab inconsistencies fixed. I wasn't entirely sure about this as it's inconsistent in the existing source, so I tried to make it as consistent as possible. Cover included again below. > Hi Lars, Thanks for sticking with this, and sorry I did not respond to the first thread. There are still one or two minor whitespace issues. If you have "uncrustify" installed, then ./devel/check-notmuch-commit && git diff will find the ones I'm thinking of. You can ignore the problems you didn't introduce. > The attached patch allows to customize the default ", " and "| " > separators in author lists. The main rationale for supporting this is > that the Python API uses the same functionality to get the list of > authors -- if I want to separate them again afterwards, I have to > split the returned string, which is error-prone with comma separators > (e.g. name in email address is of form Lastname, Firstname). Can you add a brief summary of the motivation to the commit message? > test/T030-config.sh | 2 ++ > test/T055-path-config.sh | 4 ++++ > test/T590-libconfig.sh | 10 ++++++++++ Thanks for adjusting the existing test suite. Can you also add a simple test to check the functionality you introduced? Testing the CLI is fine, or if you prefer something in the style of test/T590-libconfig.sh