unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Michal Sojka <sojkam1@fel.cvut.cz>
To: Jesse Rosenthal <jrosenthal@jhu.edu>,
	Notmuch developer list <notmuch@notmuchmail.org>
Subject: Re: [PATCH] Modularize test suite
Date: Wed, 05 May 2010 09:23:57 +0200	[thread overview]
Message-ID: <87bpcustf6.fsf@steelpick.2x.cz> (raw)
In-Reply-To: <87sk6cdbxz.fsf@jhu.edu>

On Fri, 30 Apr 2010, Jesse Rosenthal wrote:
> Responding to this email is a patch to modularize the test suite. It
> follows a relatively simple model, but it does seem like it will offer
> some degree of flexibility. Plus, no relicensing is necessary.

Hi Jesse,

Junio has just applied relicensing patch for the Git test suite
(http://git.kernel.org/?p=git/git.git;a=commit;h=64b90323f65d2a3ac8d1ff4ed73be881f76aac8a)
so we can use it for notmuch.

I have quickly looked at your modularization and I do not like that each
test resided in a separate file. I've done similar test suite for one of
my projects and it is a pain to modify the tests. If one test depends on
the previous ones, you always have to switch between multiple files in
your editor.

If you agree, I can refresh my git based modularization and send
the patches. What do you (and others) think?

Michal

  parent reply	other threads:[~2010-05-05  7:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-30 18:36 [PATCH] Modularize test suite Jesse Rosenthal
2010-04-30 18:52 ` Jesse Rosenthal
2010-04-30 19:07 ` [PATCH 1/2] test: add modular test collections Jesse Rosenthal
2010-04-30 19:09   ` [PATCH 2/2] test: Have notmuch-test use the " Jesse Rosenthal
2010-05-05  4:46     ` Jesse Rosenthal
2010-05-05  7:23 ` Michal Sojka [this message]
2010-05-05  8:04   ` [PATCH] Modularize test suite Jesse Rosenthal
2010-05-05 17:33   ` Carl Worth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bpcustf6.fsf@steelpick.2x.cz \
    --to=sojkam1@fel.cvut.cz \
    --cc=jrosenthal@jhu.edu \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).