From: Carl Worth <cworth@cworth.org>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Remove over-eager regular expressions from notmuch-wash-tidy-citations.
Date: Tue, 07 Dec 2010 14:11:03 -0800 [thread overview]
Message-ID: <87bp4x5j48.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <1290000753-20274-1-git-send-email-dme@dme.org>
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
On Wed, 17 Nov 2010 13:32:33 +0000, David Edmondson <dme@dme.org> wrote:
> The removed expressions, which were used to ensure that citations were
> both preceded and followed by a blank line, were poorly implemented
> and caused a regexp stack overflow on messages more than a few
> thousand lines long.
> ---
>
> Carl, I was not able to find a version of the regular expressions that
> didn't easily overflow. For now, this patch removes the problematic
> expressions and I'll look for a better solution.
Thanks. Applied.
-Carl
--
carl.d.worth@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2010-12-07 22:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 12:50 [PATCH] emacs: Avoid regexp overflow when tidying citations David Edmondson
2010-11-16 19:57 ` Carl Worth
2010-11-17 13:32 ` [PATCH] emacs: Remove over-eager regular expressions from notmuch-wash-tidy-citations David Edmondson
2010-12-07 22:11 ` Carl Worth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bp4x5j48.fsf@yoom.home.cworth.org \
--to=cworth@cworth.org \
--cc=dme@dme.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).