* I feel a release coming!
@ 2011-06-23 1:14 Jameson Graef Rollins
2011-06-23 1:14 ` [PATCH] emacs: Show all multipart/alternative parts by default Jameson Graef Rollins
0 siblings, 1 reply; 3+ messages in thread
From: Jameson Graef Rollins @ 2011-06-23 1:14 UTC (permalink / raw)
To: Notmuch Mail
I think we just agreed with cworth on irc that this simple patch will
satisfy his regression worry for 0.6. Meaning that we can push out
the release after this patch is merged.
bremner, our new "Release Tyrant", has his finger on the trigger...
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] emacs: Show all multipart/alternative parts by default.
2011-06-23 1:14 I feel a release coming! Jameson Graef Rollins
@ 2011-06-23 1:14 ` Jameson Graef Rollins
2011-06-23 1:51 ` David Bremner
0 siblings, 1 reply; 3+ messages in thread
From: Jameson Graef Rollins @ 2011-06-23 1:14 UTC (permalink / raw)
To: Notmuch Mail
This is patch is a temporary work-around for a slight regression that
popped up in the part handling reorganization. Currently, text/plain
parts are always preferred, if present, over other non-text/plain
parts in multipart/alternative. However, this means that if there is
a blank text/plain part, no content will be displayed.
One way to get around this is to set the
"notmuch-show-all-multipart/alternative-parts" customization variable
to True ('t'), which will cause all parts to always be displayed.
Since we want to move forward with the next release, we're going to
set this variable true by default, to make sure that no content is
unretrievably hidden from the user. Once we come up with a better
solution for easy display of hidden parts we can set this back to a
default value of 'nil'.
---
emacs/notmuch-show.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 0d9b52a..af1d44b 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -96,7 +96,7 @@ same as that of the previous message."
notmuch-wash-excerpt-citations))
;; Mostly useful for debugging.
-(defcustom notmuch-show-all-multipart/alternative-parts nil
+(defcustom notmuch-show-all-multipart/alternative-parts t
"Should all parts of multipart/alternative parts be shown?"
:group 'notmuch
:type 'boolean)
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] emacs: Show all multipart/alternative parts by default.
2011-06-23 1:14 ` [PATCH] emacs: Show all multipart/alternative parts by default Jameson Graef Rollins
@ 2011-06-23 1:51 ` David Bremner
0 siblings, 0 replies; 3+ messages in thread
From: David Bremner @ 2011-06-23 1:51 UTC (permalink / raw)
To: Jameson Graef Rollins, Notmuch Mail
On Wed, 22 Jun 2011 18:14:12 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
>
> One way to get around this is to set the
> "notmuch-show-all-multipart/alternative-parts" customization variable
> to True ('t'), which will cause all parts to always be displayed.
>
Pushed.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-23 1:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-23 1:14 I feel a release coming! Jameson Graef Rollins
2011-06-23 1:14 ` [PATCH] emacs: Show all multipart/alternative parts by default Jameson Graef Rollins
2011-06-23 1:51 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).