From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 47EFE431FD0 for ; Mon, 25 Jul 2011 13:53:17 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bq2KqvzlJxd0 for ; Mon, 25 Jul 2011 13:53:16 -0700 (PDT) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id CF9E0431FB6 for ; Mon, 25 Jul 2011 13:53:16 -0700 (PDT) Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) by fire-doxen-postvirus (Postfix) with ESMTP id ED78B328F09; Mon, 25 Jul 2011 13:53:15 -0700 (PDT) X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new Received: from finestructure.net (gwave-79.ligo.caltech.edu [131.215.114.79]) (Authenticated sender: jrollins) by fire-doxen-submit (Postfix) with ESMTP id 25D0D328EFE; Mon, 25 Jul 2011 13:53:13 -0700 (PDT) Received: by finestructure.net (Postfix, from userid 1000) id 0624F2AFC; Mon, 25 Jul 2011 13:53:13 -0700 (PDT) From: Jameson Graef Rollins To: Aaron Ecay , notmuch@notmuchmail.org Subject: Re: [PATCH] Add missing call to g_type_init() In-Reply-To: <1311625989-97755-1-git-send-email-aaronecay@gmail.com> References: <87ipqsfcpn.fsf@servo.factory.finestructure.net> <1311625989-97755-1-git-send-email-aaronecay@gmail.com> User-Agent: Notmuch/0.5-353-gb44d56e (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Mon, 25 Jul 2011 13:53:10 -0700 Message-ID: <87bowiccax.fsf@servo.factory.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2011 20:53:17 -0000 --=-=-= On Mon, 25 Jul 2011 16:33:09 -0400, Aaron Ecay wrote: > Signed-off-by: Aaron Ecay Hey, Aaron. Thanks for submitting this patch. However, you will need to provide a more detailed log message in order for it to be pulled by Carl. The commit message should explain what exactly the problem is, and how this fixes it. You also don't need to add the "Signed-off-by" for your own patches. I also forgot to mention that if there is a way to test against the issue that is raised here, then you should probably provide a patch to the test suite as well. Some bugs are just bugs, though, and there's not really a reasonable way to test for them. That may be the case here. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJOLde2AAoJEO00zqvie6q8OSsQAJVnHV3i/7eRFXzGgdfHGn1h 2G+JiUa8lHK/xyuv79AA086ODLxSdziEjQkD1lo9r+wsuP2b9BwNtK5S7FmnBIpn WvVJTxvtYLbEGUOFsXx2DrTz1qjqQ/zbnXYFOl7Ku0SdXvI8pcsJrL+vTkkW3iR6 4DenIoQKM4zafBCShf0l6ylp13i05k7lWJD5MNtctB0vmMlvBFAPrLn6ha0aFYjv xOmebI3OHiSiMQqM4342Czv2a6h7o+9L7aVaLJiaiZ/3tgcIFMZRhLRyKh4bxtKr MXrFTN4RLC7BU0E2xNPXdRECVzCFxiyb2XeDnH0m5O9PykVaSjWl5walJ2p5sRYo WEoONlffwAxXO3xtrQaeFb5xRKRbu8Bo23llAQx/pkWIhGikW4b4eW7d559qylGs MRPddgbEVhA5YDTIcoxS59CF9eFGQZwo3hjpXntjxCg8mkpDo7pwt6Z9KumOma5n FyrfiKtPPrcrM5VUxRP/ZXz6H+0PtiAioqNG0LsLbdtO+xpcGV4kJHQ/Pwemd60i UPIjeEvpy3FvXYU9fIiQWVfe8+RBQAYLQ/u1GweR8QM06ySD+xH6xGlAjEhK39TG YW4/TKhBbs1FLuLe1kdO3dNeiVILsNmmt1HEa5CqjRnHiRm3ReUSJ/yqdEi4775V oZYvkbnHmUh+GTRowtYD =cd3L -----END PGP SIGNATURE----- --=-=-=--