From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id D7B95429E4E for ; Mon, 16 Jan 2012 04:21:26 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XTHdFqC-SQLr for ; Mon, 16 Jan 2012 04:21:25 -0800 (PST) Received: from mail-qy0-f181.google.com (mail-qy0-f181.google.com [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 340DF429E4A for ; Mon, 16 Jan 2012 04:21:25 -0800 (PST) Received: by qcqw6 with SMTP id w6so1905480qcq.26 for ; Mon, 16 Jan 2012 04:21:24 -0800 (PST) Received: by 10.229.111.158 with SMTP id s30mr4352075qcp.13.1326716484569; Mon, 16 Jan 2012 04:21:24 -0800 (PST) Received: from localhost (nikula.org. [92.243.24.172]) by mx.google.com with ESMTPS id m20sm36765702qaj.14.2012.01.16.04.21.22 (version=SSLv3 cipher=OTHER); Mon, 16 Jan 2012 04:21:23 -0800 (PST) From: Jani Nikula To: Dmitry Kurochkin , David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH 1/4] emacs: unify search mechanisms In-Reply-To: <87ehuzvpul.fsf@gmail.com> References: <1324786495-14221-1-git-send-email-dmitry.kurochkin@gmail.com> <87ehuzvpul.fsf@gmail.com> User-Agent: Notmuch/0.10.2+187~g43d4f26 (http://notmuchmail.org) Emacs/23.1.1 (i686-pc-linux-gnu) Date: Mon, 16 Jan 2012 12:21:20 +0000 Message-ID: <87boq3dein.fsf@nikula.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2012 12:21:27 -0000 On Mon, 16 Jan 2012 15:39:14 +0400, Dmitry Kurochkin wrote: > On Mon, 16 Jan 2012 11:35:37 +0000, David Edmondson wrote: > > On Sun, 25 Dec 2011 08:14:52 +0400, Dmitry Kurochkin wrote: > > > Before the change, there were two ways to do search in Emacs UI: > > > search widget in notmuch-hello buffer and `notmuch-search' > > > function bound to "s". Internally, notmuch-hello search widget > > > uses `notmuch-search' function. But it uses widget field input > > > instead of minibuffer. Such duplication is a major issue for > > > notmuch-hello usability: search interface is inconsistent and > > > lacks features that are available in minibuffer (e.g. history and > > > auto completion). Some of these features may be relatively easy > > > to implement for notmuch-hello search, others would be much more > > > tricky. So to avoid duplication, make UI more consistent, bring > > > notmuch-hello search to feature parity with the minibuffer > > > search, the patch replaces notmuch-hello search widget and with a > > > button that works the same way as "s" key binding. > > > > Dmitry, if Daniel re-submits his patches to allow the construction of > > `notmuch-hello' buffers to be configured, it seems that this patchset > > would become unnecessary. Is that correct? > > Right. We will just need to fix the 's' key binding. Looking forward > for that. Isn't (something like) this still needed to merge the search histories: id:"1324698436-8532-1-git-send-email-dmitry.kurochkin@gmail.com" Jani.