From: Jani Nikula <jani@nikula.org>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
David Edmondson <dme@dme.org>,
notmuch@notmuchmail.org
Subject: Re: [PATCH 1/4] emacs: unify search mechanisms
Date: Mon, 16 Jan 2012 12:21:20 +0000 [thread overview]
Message-ID: <87boq3dein.fsf@nikula.org> (raw)
In-Reply-To: <87ehuzvpul.fsf@gmail.com>
On Mon, 16 Jan 2012 15:39:14 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> On Mon, 16 Jan 2012 11:35:37 +0000, David Edmondson <dme@dme.org> wrote:
> > On Sun, 25 Dec 2011 08:14:52 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > > Before the change, there were two ways to do search in Emacs UI:
> > > search widget in notmuch-hello buffer and `notmuch-search'
> > > function bound to "s". Internally, notmuch-hello search widget
> > > uses `notmuch-search' function. But it uses widget field input
> > > instead of minibuffer. Such duplication is a major issue for
> > > notmuch-hello usability: search interface is inconsistent and
> > > lacks features that are available in minibuffer (e.g. history and
> > > auto completion). Some of these features may be relatively easy
> > > to implement for notmuch-hello search, others would be much more
> > > tricky. So to avoid duplication, make UI more consistent, bring
> > > notmuch-hello search to feature parity with the minibuffer
> > > search, the patch replaces notmuch-hello search widget and with a
> > > button that works the same way as "s" key binding.
> >
> > Dmitry, if Daniel re-submits his patches to allow the construction of
> > `notmuch-hello' buffers to be configured, it seems that this patchset
> > would become unnecessary. Is that correct?
>
> Right. We will just need to fix the 's' key binding. Looking forward
> for that.
Isn't (something like) this still needed to merge the search histories:
id:"1324698436-8532-1-git-send-email-dmitry.kurochkin@gmail.com"
Jani.
next prev parent reply other threads:[~2012-01-16 12:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-25 4:14 [PATCH 1/4] emacs: unify search mechanisms Dmitry Kurochkin
2011-12-25 4:14 ` [PATCH 2/4] emacs: reindent `notmuch-hello' function Dmitry Kurochkin
2011-12-25 4:14 ` [PATCH 3/4] emacs: hide recent searches if `notmuch-hello-recent-searches-max' is zero Dmitry Kurochkin
2011-12-25 4:14 ` [PATCH 4/4] test: fix Emacs tests expected output after notmuch-hello search changes Dmitry Kurochkin
2011-12-30 10:44 ` [PATCH 1/4] emacs: unify search mechanisms David Edmondson
2011-12-30 14:43 ` David Bremner
2011-12-30 15:01 ` David Edmondson
2011-12-30 17:09 ` Aaron Ecay
2011-12-31 12:42 ` Jani Nikula
2011-12-31 13:06 ` David Bremner
2011-12-31 13:43 ` David Edmondson
2012-01-02 13:23 ` Tomi Ollila
2012-01-02 20:03 ` Xavier Maillard
2012-01-16 11:35 ` David Edmondson
2012-01-16 11:39 ` Dmitry Kurochkin
2012-01-16 11:47 ` David Edmondson
2012-01-16 12:21 ` Jani Nikula [this message]
2012-01-17 19:35 ` Dmitry Kurochkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87boq3dein.fsf@nikula.org \
--to=jani@nikula.org \
--cc=dme@dme.org \
--cc=dmitry.kurochkin@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).