Re: [PATCH 4/4 v42] test: Add address cleaning tests.

[Dmitry Kurochkin <dmitry.kurochkin@gmail.com>]

On Mon, 23 Jan 2012 18:05:47 +0000, David Edmondson <dme@dme.org> wrote:
> ---
> 
> Anticipate the failure of test 3.
> 

LGTM

Regards,
  Dmitry

>  test/emacs-address-cleaning.el |   29 +++++++++++++++++++++++++++++
>  test/emacs-address-cleaning.sh |   19 +++++++++++++++++++
>  test/notmuch-test              |    1 +
>  3 files changed, 49 insertions(+), 0 deletions(-)
>  create mode 100644 test/emacs-address-cleaning.el
>  create mode 100755 test/emacs-address-cleaning.sh
> 
> diff --git a/test/emacs-address-cleaning.el b/test/emacs-address-cleaning.el
> new file mode 100644
> index 0000000..59e8d92
> --- /dev/null
> +++ b/test/emacs-address-cleaning.el
> @@ -0,0 +1,29 @@
> +(defun notmuch-test-address-cleaning-1 ()
> +  (notmuch-test-compare (notmuch-show-clean-address "dme@dme.org")
> +			"dme@dme.org"))
> +
> +(defun notmuch-test-address-cleaning-2 ()
> +  (let* ((input '("foo@bar.com"
> +		  "<foo@bar.com>"
> +		  "Foo Bar <foo@bar.com>"
> +		  "foo@bar.com <foo@bar.com>"
> +		  "\"Foo Bar\" <foo@bar.com>"))
> +	 (expected '("foo@bar.com"
> +		     "foo@bar.com"
> +		     "Foo Bar <foo@bar.com>"
> +		     "foo@bar.com"
> +		     "Foo Bar <foo@bar.com>"))
> +	 (output (mapcar #'notmuch-show-clean-address input)))
> +    (notmuch-test-compare output expected)))
> +
> +(defun notmuch-test-address-cleaning-3 ()
> +  (let* ((input '("ДБ <db-uknot@stop.me.uk>"
> +		  "foo (at home) <foo@bar.com>"
> +		  "foo [at home] <foo@bar.com>"
> +		  "Foo Bar"))
> +	 (expected '("ДБ <db-uknot@stop.me.uk>"
> +		     "foo (at home) <foo@bar.com>"
> +		     "foo [at home] <foo@bar.com>"
> +		     "Foo Bar"))
> +	 (output (mapcar #'notmuch-show-clean-address input)))
> +    (notmuch-test-compare output expected)))
> diff --git a/test/emacs-address-cleaning.sh b/test/emacs-address-cleaning.sh
> new file mode 100755
> index 0000000..0d85bdc
> --- /dev/null
> +++ b/test/emacs-address-cleaning.sh
> @@ -0,0 +1,19 @@
> +#!/usr/bin/env bash
> +
> +test_description="emacs address cleaning"
> +. test-lib.sh
> +
> +test_begin_subtest "notmuch-test-address-clean part 1"
> +test_emacs_expect_t \
> +    '(load "emacs-address-cleaning.el") (notmuch-test-address-cleaning-1)'
> +
> +test_begin_subtest "notmuch-test-address-clean part 2"
> +test_emacs_expect_t \
> +    '(load "emacs-address-cleaning.el") (notmuch-test-address-cleaning-2)'
> +
> +test_begin_subtest "notmuch-test-address-clean part 3"
> +test_subtest_known_broken
> +test_emacs_expect_t \
> +    '(load "emacs-address-cleaning.el") (notmuch-test-address-cleaning-3)'
> +
> +test_done
> diff --git a/test/notmuch-test b/test/notmuch-test
> index d034f99..3f1740c 100755
> --- a/test/notmuch-test
> +++ b/test/notmuch-test
> @@ -53,6 +53,7 @@ TESTS="
>    hooks
>    argument-parsing
>    emacs-test-functions.sh
> +  emacs-address-cleaning.sh
>  "
>  TESTS=${NOTMUCH_TESTS:=$TESTS}
>  
> -- 
> 1.7.8.3
> 
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch