From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Pieter Praet <pieter@praet.org>, David Edmondson <dme@dme.org>,
David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."
Date: Wed, 01 Feb 2012 18:21:33 +0400 [thread overview]
Message-ID: <87bopimy6q.fsf@gmail.com> (raw)
In-Reply-To: <874nva7jkk.fsf@praet.org>
On Wed, 01 Feb 2012 14:46:19 +0100, Pieter Praet <pieter@praet.org> wrote:
> On Mon, 30 Jan 2012 09:23:40 +0000, David Edmondson <dme@dme.org> wrote:
> > On Sat, 28 Jan 2012 13:14:45 -0400, David Bremner <david@tethera.net> wrote:
> > > On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula <jani@nikula.org> wrote:
> > > > On Jan 28, 2012 2:41 PM, "David Bremner" <david@tethera.net> wrote:
> > > >
> > > > Sometimes someone (Dmitry?) sent patches that separated a small functional
> > > > change, and the big non-functional indentation change it caused,
> > > > separately. Would you prefer (or tolerate ;) that style?
> > >
> > > Hmm, that might be nicer, I'm not 100% sure.
> > >
> > > I wouldn't say it's mandatory for a patch like this (and I'd say other
> > > peoples views on what's easy to review are at least as important as mine
> > > here).
> >
> > Each patch should be valid in the repository without any following
> > patches (preceding are obviously okay). Incorrect indentation would
> > disqualify a patch from being 'valid', so it shouldn't be accepted.
>
> +1.
>
> Indentation corrections should always be part of the same patch as
> the change(s) that invalidated the indentation in the first place.
>
> Spotting the *actual* (non-indentation) changes is a non-issue
> when using `diff-refine-hunk' (or a wrapper thereof [1]).
>
Must... resist... getting... into... this...
next prev parent reply other threads:[~2012-02-01 14:22 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-11 21:48 [PATCH] emacs: support "notmuch new" as a notmuch-poll-script Jani Nikula
2011-12-11 22:00 ` Dmitry Kurochkin
2011-12-11 22:19 ` Jani Nikula
2011-12-11 22:39 ` Dmitry Kurochkin
2011-12-11 22:58 ` Austin Clements
2011-12-11 23:10 ` Jani Nikula
2011-12-12 0:31 ` Austin Clements
2011-12-12 0:39 ` Dmitry Kurochkin
2011-12-12 10:15 ` Tomi Ollila
2011-12-12 10:21 ` Dmitry Kurochkin
2011-12-12 11:38 ` Tomi Ollila
2011-12-12 15:42 ` Austin Clements
2011-12-12 19:57 ` [PATCH v2] " Jani Nikula
2011-12-12 20:12 ` Dmitry Kurochkin
2011-12-12 20:24 ` Austin Clements
2011-12-12 20:50 ` [PATCH v3] " Jani Nikula
2011-12-12 20:53 ` Dmitry Kurochkin
2011-12-12 21:13 ` Jani Nikula
2011-12-12 21:24 ` Austin Clements
2011-12-12 21:34 ` Dmitry Kurochkin
2011-12-12 21:01 ` Austin Clements
2011-12-15 4:24 ` David Bremner
2012-01-12 17:31 ` Pieter Praet
2012-01-12 17:33 ` [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." Pieter Praet
2012-01-12 17:40 ` Dmitry Kurochkin
2012-01-12 22:10 ` Xavier Maillard
2012-01-13 8:23 ` David Edmondson
2012-01-13 12:42 ` Xavier Maillard
2012-01-13 12:37 ` Tomi Ollila
2012-01-13 13:01 ` David Edmondson
2012-01-14 9:14 ` Pieter Praet
2012-01-14 9:17 ` [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." Pieter Praet
2012-01-28 12:41 ` David Bremner
2012-01-28 12:55 ` Jani Nikula
2012-01-28 17:14 ` David Bremner
2012-01-30 9:23 ` David Edmondson
2012-02-01 13:46 ` Pieter Praet
2012-02-01 14:21 ` Dmitry Kurochkin [this message]
2012-01-30 7:03 ` Pieter Praet
2012-01-30 7:59 ` Tomi Ollila
2012-02-01 13:46 ` Pieter Praet
2012-01-31 3:34 ` David Bremner
2012-02-01 13:47 ` Pieter Praet
2012-02-01 13:50 ` [PATCH v2] " Pieter Praet
2012-02-01 14:05 ` David Edmondson
2012-02-02 1:31 ` David Bremner
2012-01-14 9:52 ` [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." Pieter Praet
2012-01-13 16:06 ` David Edmondson
2012-01-14 9:18 ` Pieter Praet
2012-01-15 11:55 ` David Edmondson
2012-01-16 10:56 ` [PATCH v2] " Pieter Praet
2012-01-16 11:06 ` David Edmondson
2012-01-16 12:39 ` Tomi Ollila
2012-01-21 12:21 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bopimy6q.fsf@gmail.com \
--to=dmitry.kurochkin@gmail.com \
--cc=david@tethera.net \
--cc=dme@dme.org \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
--cc=pieter@praet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).