From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 0/6] Move --no-exclude to --exclude=(true|false|flag)
Date: Sun, 01 Apr 2012 15:45:46 -0700 [thread overview]
Message-ID: <87bonb5aw4.fsf@servo.finestructure.net> (raw)
In-Reply-To: <1333234442-28616-1-git-send-email-markwalters1009@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 960 bytes --]
On Sat, Mar 31 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> This is version 2 of the exclude= series (version 1 is [1]).
>
> The main changes are the addition of some systematic notmuch-search
> tests for all the exclude options, and I no longer add the
> exclude=flag option to notmuch-show.c (the output was too similar to
> exclude=false to be worth keeping).
Thanks so much for staying on top of this series. I think this is a
really important new feature and I really appreciate you ferrying it all
the way through to the finish line.
These changes are critical to the functionality as well, as the exclude
stuff currently causes severe performance degradation. So this is all
very welcome.
I've been using a previous version of this series for weeks now with no
problems at all. The emacs UI is snappy again.
This new version applies cleanly to the current master, and all tests
pass. And in my cursory review everything LGTM.
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2012-04-01 22:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-31 22:53 [PATCH v2 0/6] Move --no-exclude to --exclude=(true|false|flag) Mark Walters
2012-03-31 22:53 ` [PATCH v2 1/6] lib: change default for notmuch_query_set_omit_excluded Mark Walters
2012-04-06 1:09 ` Austin Clements
2012-03-31 22:53 ` [PATCH v2 2/6] cli: move count to the new --exclude=(true|false|flag) naming scheme Mark Walters
2012-03-31 22:53 ` [PATCH v2 3/6] cli: move search to the new --exclude= " Mark Walters
2012-04-06 1:18 ` Austin Clements
2012-03-31 22:54 ` [PATCH v2 4/6] test: add some exclude tests Mark Walters
2012-04-06 1:35 ` Austin Clements
2012-03-31 22:54 ` [PATCH v2 5/6] cli: move show to the new --exclude= option naming scheme Mark Walters
2012-03-31 22:54 ` [PATCH v2 6/6] emacs: make show set --exclude=false Mark Walters
2012-04-01 22:45 ` Jameson Graef Rollins [this message]
2012-04-06 2:24 ` [PATCH v2 0/6] Move --no-exclude to --exclude=(true|false|flag) Austin Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bonb5aw4.fsf@servo.finestructure.net \
--to=jrollins@finestructure.net \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).