From: Mark Walters <markwalters1009@gmail.com>
To: Damien Cassou <damien.cassou@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3] emacs: display tags in notmuch-show with links
Date: Mon, 10 Dec 2012 16:05:23 +0000 [thread overview]
Message-ID: <87boe1yjss.fsf@qmul.ac.uk> (raw)
In-Reply-To: <1355149964-27905-1-git-send-email-damien.cassou@gmail.com>
On Mon, 10 Dec 2012, Damien Cassou <damien.cassou@gmail.com> wrote:
> This patch obsoletes:
> id:1353266322-20318-1-git-send-email-damien.cassou@gmail.com
>
> [PATCH 1/4] emacs: Add a thread's tags to notmuch-show header-line
> [PATCH 2/4] emacs: Make tags in notmuch-show header-line clickable
> [PATCH 3/4] emacs: Make all tags in `notmuch-show' clickable
> [PATCH 4/4] emacs: Add unit-tests for clickable tags
>
> This patch makes clickable all tags that appear in notmuch-show
> buffers. Each tag is a link to open a new notmuch-search buffer for
> this tag. Additionally, the buffer's header-line now shows the
> thread's tags (clickable only if the `header-button' library is loaded
> or loadable).
>
> This patch is the first one of an upcoming series whose goal is to
> integrate notmuch-labeler into notmuch. See the following for more
> details:
> https://github.com/DamienCassou/notmuch-labeler
Hi
I like this series but there are two (related) problems that I missed on
earlier review.
The first is that the headerline tags are not updated when the user tags
a message, and the second is that the tags for the message itself (ie in
the emacs buffer not the headerline) are updated but cease to be
buttons.
I think the function notmuch-show-update-tags is the one that does the
updating of the display. (Incidentally that seems to break if the user
likes tags containing brackets).
This is probably the place to link to as there are lots of ways messages
get tagged.
Best wishes (and sorry for not catching this before)
Mark
>
> With respect to v2, I took care of the comments you made:
> - moved notmuch-tagger-separate-elems to notmuch-lib
> - renamed a few methods
> - changed some comments to better reflect the method behavior
> - changed links in the body so that TAB won't stop at them
> - changed miscellaneous small things
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
prev parent reply other threads:[~2012-12-10 16:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 14:32 [PATCH v3] emacs: display tags in notmuch-show with links Damien Cassou
2012-12-10 14:32 ` [PATCH 1/4] emacs: Add a thread's tags to notmuch-show header-line Damien Cassou
2012-12-10 14:32 ` [PATCH 2/4] emacs: Make tags in notmuch-show header-line clickable Damien Cassou
2012-12-10 14:32 ` [PATCH 3/4] emacs: Make all tags in `notmuch-show' clickable Damien Cassou
2012-12-10 14:32 ` [PATCH 4/4] emacs: Add unit-tests for clickable tags Damien Cassou
2012-12-10 16:05 ` Mark Walters [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87boe1yjss.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=damien.cassou@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).