unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/6] lib: Clean up error handling in _notmuch_thread_create
Date: Mon, 18 Feb 2013 21:16:42 -0400	[thread overview]
Message-ID: <87bobhumpx.fsf@zancas.localnet> (raw)
In-Reply-To: <87fw0tumuy.fsf@zancas.localnet>

David Bremner <david@tethera.net> writes:

> Austin Clements <amdragon@MIT.EDU> writes:
>
>> Previously, there were various opportunities for memory leaks in the
>> error-handling paths of this function.  Use a local talloc context and
>> some reparenting to make eliminate these leaks, while keeping the
>> control flow simple.
>
> pushed all but the python bindings patch.

any comments on that patch, Justus?

For reference, id:1353819427-13182-6-git-send-email-amdragon@mit.edu

d

  reply	other threads:[~2013-02-19  1:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-25  4:57 [PATCH 0/6] API for iterating over all messages in a thread Austin Clements
2012-11-25  4:57 ` [PATCH 1/6] lib: Clean up error handling in _notmuch_thread_create Austin Clements
2013-02-19  1:13   ` David Bremner
2013-02-19  1:16     ` David Bremner [this message]
2012-11-25  4:57 ` [PATCH 2/6] lib: Separate list of all messages from top-level messages Austin Clements
2012-11-25  4:57 ` [PATCH 3/6] lib: Eliminate _notmuch_message_list_append Austin Clements
2012-11-25  4:57 ` [PATCH 4/6] lib: Add an iterator over all messages in a thread Austin Clements
2012-11-25  4:57 ` [PATCH 5/6] python: Add bindings for notmuch_thread_get_messages Austin Clements
2013-05-04 18:51   ` David Bremner
2013-05-05 17:00   ` David Bremner
2012-11-25  4:57 ` [PATCH 6/6] ruby: " Austin Clements
2012-11-26 16:23   ` Ali Polatel
2012-11-25 14:31 ` [PATCH 0/6] API for iterating over all messages in a thread Mark Walters
2012-11-25 21:20   ` Austin Clements
2012-11-26 17:19     ` Tomi Ollila
2012-11-26 17:35       ` Austin Clements

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bobhumpx.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=amdragon@MIT.EDU \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).