From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id DD0B6431FAF for ; Thu, 7 Mar 2013 05:44:55 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KoUCDMYmb6Z3 for ; Thu, 7 Mar 2013 05:44:55 -0800 (PST) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 622D1431FAE for ; Thu, 7 Mar 2013 05:44:55 -0800 (PST) Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.82.78] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1UDb7r-0006Th-84; Thu, 07 Mar 2013 09:44:51 -0400 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1UDb7l-0007VF-FM; Thu, 07 Mar 2013 09:44:45 -0400 From: David Bremner To: Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH v2 4/6] cli: config: make notmuch_config_open() "is new" parameter input only In-Reply-To: <5faebfc5d36d7e85a4dd1acbca0417d8a6a2602d.1362347362.git.jani@nikula.org> References: <5faebfc5d36d7e85a4dd1acbca0417d8a6a2602d.1362347362.git.jani@nikula.org> User-Agent: Notmuch/0.15.2+32~g16aa65b (http://notmuchmail.org) Emacs/24.2.1 (x86_64-pc-linux-gnu) Date: Thu, 07 Mar 2013 09:44:45 -0400 Message-ID: <87boavxr1u.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2013 13:44:56 -0000 Jani Nikula writes: > We now have a notmuch_config_is_new() function to query whether a > config was created or not. Change the notmuch_config_open() is_new > parameter into boolean create_new to determine whether the function > should create a new config if one doesn't exist. This reduces the > complexity of the API. I have pushed the first 4 patches in this series. I'd like a second (third?) pair of eyes on 5/6. d