[PATCH] news: Be louder about s/v/o on part buttons going away

[PATCH] news: Be louder about s/v/o on part buttons going away

[Austin Clements]

This change is likely to affect most people, so put this information
right in the news header and be more explicit about it in the news
detail.
---
 NEWS |   19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/NEWS b/NEWS
index 6f09cdb..0c0cf82 100644
--- a/NEWS
+++ b/NEWS
@@ -66,15 +66,16 @@ notmuch-vim, but of course that is their decision.
 Emacs Interface
 ---------------
 
-New keymap to view/save parts
-
-  To view or save a single MIME part of a message, use the new "."
-  submap (e.g., ". s" to save, ". v" to view).  Previously, these keys
-  were only available when point was on a part button and they did not
-  have the "." prefix, so they were difficult to invoke (impossible if
-  a part did not have a button) and clashed with other bindings.
-  These new bindings also appear in show's help, so you don't have to
-  memorize them.
+New keymap to view/save parts; removed s/v/o part button bindings
+
+  The commands to view, save, and open MIME parts are now prefixed
+  with "." (". s" to save, ". v" to view, etc) and can be invoked with
+  point anywhere in a part, unlike the old commands, which were
+  restricted to part buttons.  The old "s"/"v"/"o" commands on part
+  buttons have been removed since they clashed with other bindings
+  (notably "s" for search!) and could not be invoked when there was no
+  part button.  The new, prefixed bindings appear in show's help, so
+  you no longer have to memorize them.
 
 Default part save directory is now `mm-default-directory`
 
-- 
1.7.10.4

Re: [PATCH] news: Be louder about s/v/o on part buttons going away

[Mark Walters]

Austin Clements <amdragon@MIT.EDU> writes:

> This change is likely to affect most people, so put this information
> right in the news header and be more explicit about it in the news
> detail.
> ---
>  NEWS |   19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/NEWS b/NEWS
> index 6f09cdb..0c0cf82 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -66,15 +66,16 @@ notmuch-vim, but of course that is their decision.
>  Emacs Interface
>  ---------------
>  
> -New keymap to view/save parts
> -
> -  To view or save a single MIME part of a message, use the new "."
> -  submap (e.g., ". s" to save, ". v" to view).  Previously, these keys
> -  were only available when point was on a part button and they did not
> -  have the "." prefix, so they were difficult to invoke (impossible if
> -  a part did not have a button) and clashed with other bindings.
> -  These new bindings also appear in show's help, so you don't have to
> -  memorize them.
> +New keymap to view/save parts; removed s/v/o part button bindings
> +
> +  The commands to view, save, and open MIME parts are now prefixed
> +  with "." (". s" to save, ". v" to view, etc) and can be invoked with
> +  point anywhere in a part, unlike the old commands, which were
> +  restricted to part buttons.  The old "s"/"v"/"o" commands on part
> +  buttons have been removed since they clashed with other bindings
> +  (notably "s" for search!) and could not be invoked when there was no
> +  part button.  The new, prefixed bindings appear in show's help, so
> +  you no longer have to memorize them.

Looks good to me but probably worth adding the | key for piping a part?

Best wishes

Mark


>  
>  Default part save directory is now `mm-default-directory`
>  
> -- 
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v2] news: Be louder about s/v/o/| on part buttons going away

[Austin Clements]

This change is likely to affect most people, so put this information
right in the news header and be more explicit about it in the news
detail.
---

As Mark pointed out, I forgot to mention the | part command.

 NEWS |   19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/NEWS b/NEWS
index 6f09cdb..5f0e15f 100644
--- a/NEWS
+++ b/NEWS
@@ -66,15 +66,16 @@ notmuch-vim, but of course that is their decision.
 Emacs Interface
 ---------------
 
-New keymap to view/save parts
-
-  To view or save a single MIME part of a message, use the new "."
-  submap (e.g., ". s" to save, ". v" to view).  Previously, these keys
-  were only available when point was on a part button and they did not
-  have the "." prefix, so they were difficult to invoke (impossible if
-  a part did not have a button) and clashed with other bindings.
-  These new bindings also appear in show's help, so you don't have to
-  memorize them.
+New keymap to view/save parts; removed s/v/o/| part button bindings
+
+  The commands to view, save, and open MIME parts are now prefixed
+  with "." (". s" to save, ". v" to view, etc) and can be invoked with
+  point anywhere in a part, unlike the old commands, which were
+  restricted to part buttons.  The old "s"/"v"/"o"/"|" commands on
+  part buttons have been removed since they clashed with other
+  bindings (notably "s" for search!) and could not be invoked when
+  there was no part button.  The new, prefixed bindings appear in
+  show's help, so you no longer have to memorize them.
 
 Default part save directory is now `mm-default-directory`
 
-- 
1.7.10.4

Re: [PATCH v2] news: Be louder about s/v/o/| on part buttons going away

[David Bremner]

Austin Clements <amdragon@MIT.EDU> writes:

> This change is likely to affect most people, so put this information
> right in the news header and be more explicit about it in the news
> detail.

pushed.

d