From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: Re: Fix count/search query destructiveness
Date: Tue, 06 Sep 2016 07:37:21 -0300 [thread overview]
Message-ID: <87bn01iaam.fsf@zancas.localnet> (raw)
In-Reply-To: <20160905154806.4570-1-david@tethera.net>
David Bremner <david@tethera.net> writes:
> As discussed in id:147263183913.27784.12274024193186585889@mbp, the
> current behaviour is destructive due to exclude handling. This makes
> some natural code, including notmuch-reply, buggy.
Mark points out on IRC that notmuch-reply doesn't use excludes, so it's
not buggy just confusing. So the current documentation should be
something like "the query functions are non-destructive, unless you use
excludes". That makes these changes somewhat less urgent; I still think
they're probably a good idea, since the current is not very nice, and a
bit hard to document/understand.
prev parent reply other threads:[~2016-09-06 10:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 15:48 Fix count/search query destructiveness David Bremner
2016-09-05 15:48 ` [PATCH 1/5] lib: eagerly parse queries David Bremner
2016-09-05 15:48 ` [PATCH 2/5] lib/query: make query parsing lazy again, keep centralized David Bremner
2016-09-05 15:48 ` [PATCH 3/5] test: add known broken test for nondestructiveness of count David Bremner
2016-09-05 15:48 ` [PATCH 4/5] lib: query make exclude handling non-destructive David Bremner
2016-09-06 10:39 ` David Bremner
2016-09-05 15:48 ` [PATCH 5/5] lib: make notmuch_query_add_tag_exclude return a status value David Bremner
2016-09-06 11:20 ` David Bremner
2016-09-06 10:37 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bn01iaam.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).