From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id D3A3E6DE0183
 for <notmuch@notmuchmail.org>; Thu, 19 Oct 2017 04:52:49 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.011,
 SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 8f2Im6dfLnPv for <notmuch@notmuchmail.org>;
 Thu, 19 Oct 2017 04:52:49 -0700 (PDT)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id E2BC76DE012F
 for <notmuch@notmuchmail.org>; Thu, 19 Oct 2017 04:52:48 -0700 (PDT)
Received: from remotemail by fethera.tethera.net with local (Exim 4.89)
 (envelope-from <david@tethera.net>)
 id 1e59Jj-000412-Sk; Thu, 19 Oct 2017 07:48:51 -0400
Received: (nullmailer pid 32317 invoked by uid 1000);
 Thu, 19 Oct 2017 11:52:46 -0000
From: David Bremner <david@tethera.net>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
 Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH v6 06/14] reindex: drop all properties named with prefix
 "index."
In-Reply-To: <20171017191008.8742-7-dkg@fifthhorseman.net>
References: <20171017191008.8742-1-dkg@fifthhorseman.net>
 <20171017191008.8742-7-dkg@fifthhorseman.net>
Date: Thu, 19 Oct 2017 08:52:46 -0300
Message-ID: <87bml3icc1.fsf@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Oct 2017 11:52:49 -0000

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> +    ret = notmuch_message_remove_all_properties_with_prefix (message, "index.");
> +    if (ret) {
> +	INTERNAL_ERROR ("failed to remove index.* properties");
> +	goto DONE;
> +    }

1) INTERNAL_ERROR is fatal, so the goto is unneeded / confusing.

2) Is there no sensible return value here? The function already has an
error return path. I see there is one INTERNAL_ERROR there so maybe
similar reasoning applies and a TODO is enough.