From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id A73D66DE1416 for ; Mon, 6 May 2019 14:15:19 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.161 X-Spam-Level: X-Spam-Status: No, score=-0.161 tagged_above=-999 required=5 tests=[AWL=0.040, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4SmQW_RZIK1h for ; Mon, 6 May 2019 14:15:19 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTPS id F22996DE0F9A for ; Mon, 6 May 2019 14:15:18 -0700 (PDT) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1557177317; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=Bj5QxQB/in+Gvzbd7phnRPUxrqdHEYJLu2rj/LXG8xk=; b=nbVlcHMzlXYZkfnSEBRGeN8LF0Q4Xv/or2V2N01dDRDjNCHU96yfmMqP 9J8Ct4lQl+CCERtUPH5UYZ3WLDx9DQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1557177317; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=Bj5QxQB/in+Gvzbd7phnRPUxrqdHEYJLu2rj/LXG8xk=; b=kXFfDzqmf9/Wq744s8GMrmFUftZor1q8Fa3knOTh73JFH5hsuXtR5Zka bxbyab77tn6rP8hpFh/YZvPNC+qdas1Rc2f/l0k1Bgs4wLeAPtP711EFKb tILqvofWUnHfe16gMl3wpWrbFn2AuCQUq4Mwc6ajQ7DrcUqk7MqGp0i2Uo 6mgnfzWv9FWQ9z7RJfY4Eb0Z/6R2tz/QUQZAu6Ct5YPs8BAQi+5JbYn7ZZ TQCXe8rqVosoNUnfpSJrAWZvPh09kLp7FYHeQGtidftwkExFZprT45LL00 4ZL+qZ6cMfOqZ2uXAQ8I7jhSPQt8uihpW4IDbdRNCtmKebBJNxgV3g== Received: from fifthhorseman.net (unknown [38.109.115.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id F23E5F99F; Mon, 6 May 2019 17:15:14 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 45593203ED; Mon, 6 May 2019 16:55:18 -0400 (EDT) From: Daniel Kahn Gillmor To: Tomi Ollila , David Bremner , "Rollins\, Jameson" , Notmuch Mail Subject: Re: [PATCH] test: add configurable port to smtp-dummy In-Reply-To: References: <20190506044406.6900-1-jrollins@caltech.edu> <20190506103230.23669-1-david@tethera.net> Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEXEK/AhYJKwYBBAHaRw8BAQdAr/gSROcn+6m8ijTN0DV9AahoHGafy52RRkhCZVwxhEe0K0Rh bmllbCBLYWhuIEdpbGxtb3IgPGRrZ0BmaWZ0aGhvcnNlbWFuLm5ldD6ImQQTFggAQQIbAQUJA8Jn AAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBMS8Lds4zOlkhevpwvIGkReQOOXGBQJcQsbzAhkB AAoJEPIGkReQOOXG4fkBAO1joRxqAZY57PjdzGieXLpluk9RkWa3ufkt3YUVEpH/AP9c+pgIxtyW +FwMQRjlqljuj8amdN4zuEqaCy4hhz/1DbgzBFxCv4sWCSsGAQQB2kcPAQEHQERSZxSPmgtdw6nN u7uxY7bzb9TnPrGAOp9kClBLRwGfiPUEGBYIACYWIQTEvC3bOMzpZIXr6cLyBpEXkDjlxgUCXEK/ iwIbAgUJAeEzgACBCRDyBpEXkDjlxnYgBBkWCAAdFiEEyQ5tNiAKG5IqFQnndhgZZSmuX/gFAlxC v4sACgkQdhgZZSmuX/iVWgD/fCU4ONzgy8w8UCHGmrmIZfDvdhg512NIBfx+Mz9ls5kA/Rq97vz4 z48MFuBdCuu0W/fVqVjnY7LN5n+CQJwGC0MIA7QA/RyY7Sz2gFIOcrns0RpoHr+3WI+won3xCD8+ sVXSHZvCAP98HCjDnw/b0lGuCR7coTXKLIM44/LFWgXAdZjm1wjODbg4BFxCv50SCisGAQQBl1UB BQEBB0BG4iXnHX/fs35NWKMWQTQoRI7oiAUt0wJHFFJbomxXbAMBCAeIfgQYFggAJhYhBMS8Lds4 zOlkhevpwvIGkReQOOXGBQJcQr+dAhsMBQkB4TOAAAoJEPIGkReQOOXGe/cBAPlek5d9xzcXUn/D kY6jKmxe26CTws3ZkbK6Aa5Ey/qKAP0VuPQSCRxA7RKfcB/XrEphfUFkraL06Xn/xGwJ+D0hCw== Date: Mon, 06 May 2019 16:55:17 -0400 Message-ID: <87bm0fmhfu.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 May 2019 21:15:19 -0000 --=-=-= Content-Type: text/plain On Mon 2019-05-06 22:39:26 +0300, Tomi Ollila wrote: > we run smtp-dummy as: > > smtp_dummy_pid= > eval `$TEST_DIRECTORY/smtp-dummy --background sent_message` > > if process binds using port `0` system fill find available port for it... > > ... which smtp-dummy could return in a variable to be evaluated ... > > ... and that could replace all this what has been done here ... i agree with Tomi that something like this (smtp-dummy asks for an available port and reports it), is the ideal solution, in that it means that two copies of the notmuch testsuite itself could even run independently and avoid contending for system resources. but i think Bremner's manually-set port is a completely reasonable first step, and we can adopt the proposed optimization later. LGTM. --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQTJDm02IAobkioVCed2GBllKa5f+AUCXNCfNQAKCRB2GBllKa5f +FSNAP9dsriJDO1HCZjTXJIfqHWdk8+hQZnFBN8cGqSdAS159QEA3UjihO5Y6eab ONDsUjsf8DXIGNfD7PIzILD1XL3CSws= =0OWx -----END PGP SIGNATURE----- --=-=-=--