unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: "Örjan Ekeberg" <ekeberg@kth.se>
To: notmuch@notmuchmail.org
Subject: [BUG] emacs: notmuch-mua-attachment-check finds triggering string inside forwarded messages
Date: Wed, 08 May 2019 19:19:18 +0200	[thread overview]
Message-ID: <87bm0cc19l.fsf@swing.csc.kth.se> (raw)

Hi all,

I have found what seems to be a bug, or at least a misbehaviour of the
"missing attachment warning" implemented by the otherwise so nice
notmuch-mua-attachment-check.

It works fine to detect the regexp for attachments in simple messages.
The problem is that it also triggers the warning if a matching string is
present inside a forwarded message.  This is particularly annoying when
forwarding messages originating from MS-Exchange since those seem to
always include a hidden header "X-MS-Has-Attach" where the word "Attach"
constantly leads to false missing-attachment warnings.

Would it be possible to somehow restrict the regexp search to the part
of the message actually being authored?  Would it be too simplistic to
end the search at the first occurrence of "\n\n<#" ?

/Örjan

             reply	other threads:[~2019-05-08 17:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-08 17:19 Örjan Ekeberg [this message]
2019-06-09 23:12 ` [BUG] emacs: notmuch-mua-attachment-check finds triggering string inside forwarded messages Daniel Kahn Gillmor
2019-12-12 23:35 ` [PATCH 0/2] Limit attachment check to stop before forwarded message ekeberg
2019-12-12 23:35   ` [PATCH 1/2] emacs: limit search for attachment to stop at first mime-part ekeberg
2019-12-12 23:35   ` [PATCH 2/2] test: extend test of attachment warnings ekeberg
2019-12-13 10:26   ` [PATCH 0/2] Limit attachment check to stop before forwarded message David Edmondson
2019-12-14 11:39   ` David Bremner
2021-12-25 18:04 ` [BUG] emacs: notmuch-mua-attachment-check finds triggering string inside forwarded messages David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bm0cc19l.fsf@swing.csc.kth.se \
    --to=ekeberg@kth.se \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).