From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id ECCF26DE0F6A for ; Wed, 22 May 2019 04:49:53 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.037 X-Spam-Level: X-Spam-Status: No, score=-0.037 tagged_above=-999 required=5 tests=[AWL=-0.036, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mhjzxSwIUDnL for ; Wed, 22 May 2019 04:49:53 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id EB1AF6DE0F18 for ; Wed, 22 May 2019 04:49:52 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1hTPki-000591-8O; Wed, 22 May 2019 07:49:48 -0400 Received: (nullmailer pid 24113 invoked by uid 1000); Wed, 22 May 2019 11:49:50 -0000 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH] test: redirect STDIN from /dev/tty In-Reply-To: References: <20190521201702.28754-1-tomi.ollila@iki.fi> <87h89ntfod.fsf@tethera.net> Date: Wed, 22 May 2019 08:49:50 -0300 Message-ID: <87blzuu2sh.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 May 2019 11:49:54 -0000 Tomi Ollila writes: > On Tue, May 21 2019, David Bremner wrote: > >> Tomi Ollila writes: >> >>> Without this stdin may be anything that parent process provided for it. >>> >>> Test processes might have tried to read something from it, which would >>> have caused undeterministic behavior. >>> >>> E.g. gdb(1) tries to do tty related ioctls on fd 0 (and fd 1 and fd 2, >>> but those are redirected to 'test.output' before test runs). >>> --- >>> >>> Hopefully this fixes the parallel problems -- In case of moreutils parallel >>> only stdout and stderr are captured and all other fd's left untouched >>> (provided I read web namual correctly). With GNU parallel docs did not >>> help -- but as we pipe $TESTS to parallel in that case things might be >>> even more complicated there (i don't undersand why but anyway) >> >> I can confirm that this seems to fix the parallel test problems with >> moreutils parallel and GNU. >> >> I think I'm leaning towards this fix between the two, but I'll sleep on >> it and decide tommorow. > > ... and when you merge this one, please amend /dev/tty -> /dev/null > --- in subject line of the commit message ;D Done, and pushed. d