Re: [PATCH] test: redirect STDIN from /dev/tty

[David Bremner <david@tethera.net>]

Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Tue, May 21 2019, David Bremner wrote:
>
>> Tomi Ollila <tomi.ollila@iki.fi> writes:
>>
>>> Without this stdin may be anything that parent process provided for it.
>>>
>>> Test processes might have tried to read something from it, which would
>>> have caused undeterministic behavior.
>>>
>>> E.g. gdb(1) tries to do tty related ioctls on fd 0 (and fd 1 and fd 2,
>>> but those are redirected to 'test.output' before test runs).
>>> ---
>>>
>>> Hopefully this fixes the parallel problems -- In case of moreutils parallel
>>> only stdout and stderr are captured and all other fd's left untouched
>>> (provided I read web namual correctly). With GNU parallel docs did not
>>> help -- but as we pipe $TESTS to parallel in that case things might be
>>> even more complicated there (i don't undersand why but anyway)
>>
>> I can confirm that this seems to fix the parallel test problems with
>> moreutils parallel and GNU.
>>
>> I think I'm leaning towards this fix between the two, but I'll sleep on
>> it and decide tommorow.
>
> ... and when you merge this one, please amend /dev/tty -> /dev/null 
> --- in subject line of the commit message ;D

Done, and pushed.

d