From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id DF6446DE0BA5 for ; Tue, 3 Sep 2019 16:49:16 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.055 X-Spam-Level: X-Spam-Status: No, score=-0.055 tagged_above=-999 required=5 tests=[AWL=-0.054, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mLtAJT3s2O2r for ; Tue, 3 Sep 2019 16:49:16 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 2132F6DE0B78 for ; Tue, 3 Sep 2019 16:49:15 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1i5IXy-0003Ad-CT; Tue, 03 Sep 2019 19:49:14 -0400 Received: (nullmailer pid 7029 invoked by uid 1000); Tue, 03 Sep 2019 23:49:13 -0000 From: David Bremner To: David Edmondson , notmuch@notmuchmail.org Cc: Daniel Kahn Gillmor Subject: Re: [PATCH v3 0/4] Retrieve GPG keys asynchronously. In-Reply-To: <20181001160633.26775-1-dme@dme.org> References: <20181001160633.26775-1-dme@dme.org> X-List-To: notmuch Date: Tue, 03 Sep 2019 20:49:13 -0300 Message-ID: <87blw1rldy.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2019 23:49:17 -0000 David Edmondson writes: > Retrieve GPG keys asynchronously. > > v2: > - Update the label on buttons when they are used to request > asyncronous key retrieval. > - Always update the buffer when key retrieval completes, even if the > retrieval failed, so that the label is properly re-generated. > > v3: > - Code review comments from bremner: > - Fix spelling. > - Fix button label. > - Update docstring to describe the redisplay conditions. > I went back to this series to try and do the last minor things my self, but unfortunately I got lost in trying to do the rebase. I think it collides with a couple of dkg's fixes (9300defd6 and 3c752b855f). If either of you has (or can make) a version of this series that applies cleanly to master, I'd like to get it merged (perhaps with one or two minor tweaks that I could take care of). d