From: David Bremner <david@tethera.net>
To: Felipe Contreras <felipe.contreras@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 04/10] ruby: simplify data get helper
Date: Wed, 12 May 2021 18:59:39 -0300 [thread overview]
Message-ID: <87bl9ffwac.fsf@tethera.net> (raw)
In-Reply-To: <20210504081749.715768-5-felipe.contreras@gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
> The type is not actually needed.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
> bindings/ruby/defs.h | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/bindings/ruby/defs.h b/bindings/ruby/defs.h
> index 46e2caf8..8fb47b4c 100644
> --- a/bindings/ruby/defs.h
> +++ b/bindings/ruby/defs.h
> @@ -55,39 +55,39 @@ extern ID ID_db_mode;
> # define RSTRING_PTR(v) (RSTRING((v))->ptr)
> #endif /* !defined (RSTRING_PTR) */
>
> -#define Data_Get_Notmuch_Object(obj, type, message, ptr) \
> +#define Data_Get_Notmuch_Object(obj, message, ptr) \
> do { \
> - Data_Get_Struct ((obj), type, (ptr)); \
> + (ptr) = rb_data_object_get ((obj)); \
Please explain a bit more in the commit message what's going on
here. Why is it OK to replace Data_Get_Struct with rb_data_object_get?
next prev parent reply other threads:[~2021-05-12 21:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 8:17 [PATCH v2 00/10] ruby: object cleanups Felipe Contreras
2021-05-04 8:17 ` [PATCH v2 01/10] ruby: add missing Data_Get_Notmuch helpers Felipe Contreras
2021-05-04 8:17 ` [PATCH v2 02/10] ruby: improve all Data_Get_Notmuch_* helpers Felipe Contreras
2021-05-04 8:17 ` [PATCH v2 03/10] ruby: improve general data get helper Felipe Contreras
2021-05-12 22:38 ` David Bremner
2021-05-04 8:17 ` [PATCH v2 04/10] ruby: simplify " Felipe Contreras
2021-05-12 21:59 ` David Bremner [this message]
2021-05-13 2:17 ` Felipe Contreras
2021-05-04 8:17 ` [PATCH v2 05/10] ruby: fetch class name in case of error Felipe Contreras
2021-05-04 8:17 ` [PATCH v2 06/10] ruby: add unlikely hint Felipe Contreras
2021-05-04 8:17 ` [PATCH v2 07/10] ruby: create Data_Wrap_Notmuch_Object helper Felipe Contreras
2021-05-04 8:17 ` [PATCH v2 08/10] ruby: move towards more modern RTypedData Felipe Contreras
2021-05-12 22:02 ` David Bremner
2021-05-13 2:23 ` Felipe Contreras
2021-05-04 8:17 ` [PATCH v2 09/10] ruby: add all data types Felipe Contreras
2021-05-04 8:17 ` [PATCH v2 10/10] ruby: new notmuch_rb_object_destroy() helper Felipe Contreras
2021-05-12 22:10 ` David Bremner
2021-05-13 2:31 ` Felipe Contreras
2021-05-04 8:25 ` [PATCH v2 00/10] ruby: object cleanups Felipe Contreras
2021-05-11 19:04 ` Felipe Contreras
2021-05-11 19:41 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl9ffwac.fsf@tethera.net \
--to=david@tethera.net \
--cc=felipe.contreras@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).