From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +BhQCJC02GBeIwEAgWs5BA (envelope-from ) for ; Sun, 27 Jun 2021 19:25:36 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id wIgCBJC02GCGMQAAB5/wlQ (envelope-from ) for ; Sun, 27 Jun 2021 17:25:36 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6D1E72715C for ; Sun, 27 Jun 2021 19:25:35 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 1915326A0A; Sun, 27 Jun 2021 13:25:32 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id DF38026A09 for ; Sun, 27 Jun 2021 13:25:28 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id C4C2F5FD21; Sun, 27 Jun 2021 13:25:28 -0400 (EDT) Received: (nullmailer pid 846428 invoked by uid 1000); Sun, 27 Jun 2021 17:25:27 -0000 From: David Bremner To: edef , notmuch@notmuchmail.org Subject: Re: [PATCH v2] emacs: remap send-message and send-message-and-exit In-Reply-To: <20210613082357.76606-1-edef@edef.eu> References: <20210613082357.76606-1-edef@edef.eu> Date: Sun, 27 Jun 2021 14:25:27 -0300 Message-ID: <87bl7r1apk.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: XZETILQZIOOOIETUU5UGCUWUD7TYQCM5 X-Message-ID-Hash: XZETILQZIOOOIETUU5UGCUWUD7TYQCM5 X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: edef X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624814735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=qD0caQfp4HiJ4s4U6S1I1cXLM0S779f5fhm8Q8t1X5o=; b=hK/ywwKcXVx4EMZ9lfz7WPriCJOYDMItvdxIvrsvdxq36blJHiTIfd7brQWQYIPdW1Nyhe 0B/x6oKNLkt57cAYl6p3nk0twcQQew5U1/t3//d7tPwTEOItnQMpzI8vPHav2Hk/s0g3rr MJGJ5tHMwXdY8N6ABAJTC0T3GB1UydDhNNzqdLk7G16NrZD4mXe9qLKIAqeR/MqecvcZDa QCZNNSZy/n9fVrUQQhXYu9/HoZzsx8TNvHJ0594OrrksE/JkcCIJ75zLG7dSNZTujyjLBn 9/hiozlWga1Y2JxHzebwDFd1D6ThhvegInO4AhoaGKIBJ4TlO2uvVJ+vmwZ0qA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624814735; a=rsa-sha256; cv=none; b=CrMhg+wz+Eu4pDcbqzoz0OpIEXWidAyPzbgsZa1n7tDLfjAb+KkyTeki7uxBPBLUl6qQ3Z jPY3fZ0nOKdjooAQJplHP4EiIscqGf+sONF6Yootxp9O3q1d5bVaMWSQyPhJsTtYwDyq2O AkWEBn1w9sWu4c4YPYU0T//s4wM77BO4/rk7LaUJ8b2nvzmInI27m/K/gFAguM2wW0TLmS 4IMLZQnPsySfj7YLSowGSD1Q7I2/mvGRIQODbCwamGonwAKN/LIdo+ZAc3/EcbxFl7zGDl rYoY4rV9VqJkSx8UcZWrRW295xwboD9XPoQj2UmpUm127ehBcqG7CeXyLTLLVg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.07 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 6D1E72715C X-Spam-Score: -2.07 X-Migadu-Scanner: scn0.migadu.com X-TUID: /Bj2PI+7f7rb edef writes: > All three of C-c C-c, , > and are bound to message-send-and-exit by > message.el, but notmuch-mua.el only had an explicit override for the > keyboard binding. This mostly manifests as confusing Fcc behaviour for > GUI users. > > Patching the bindings for specific keys is rather brittle, since it has > to be aware of every relevant binding. This change switches to instead > using a remap binding, which turns any binding for message-send or > message-send-and-exit into a binding for the corresponding notmuch-mua > command. > --- > Fixed up the nits reported by Tomi Ollila. applied to master, thanks d