From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sAokFze5xGFSNwAAgWs5BA (envelope-from ) for ; Thu, 23 Dec 2021 19:00:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id CNfgEje5xGGdBgAA1q6Kng (envelope-from ) for ; Thu, 23 Dec 2021 18:00:23 +0000 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C138129DD7 for ; Thu, 23 Dec 2021 19:00:22 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 4871C5F711; Thu, 23 Dec 2021 18:00:18 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id E99075F401 for ; Thu, 23 Dec 2021 18:00:14 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id CFBBC5FC42; Thu, 23 Dec 2021 13:00:13 -0500 (EST) Received: (nullmailer pid 1963237 invoked by uid 1000); Thu, 23 Dec 2021 18:00:12 -0000 From: David Bremner To: "Naveen N. Rao" , notmuch@notmuchmail.org Subject: Re: 'notmuch search thread:<>' lists multiple threads In-Reply-To: <1524045467.a0aq8zermb.naveen@linux.ibm.com> References: <1523007700.l8xm6nm6af.naveen@linux.ibm.com> <87sh86v1oc.fsf@tethera.net> <878t9wvbmu.fsf@tethera.net> <1524045467.a0aq8zermb.naveen@linux.ibm.com> Date: Thu, 23 Dec 2021 14:00:12 -0400 Message-ID: <87bl17i4lv.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: IR6MZQ7ONRE4KSI5TUK33WUHF7JGZ7QQ X-Message-ID-Hash: IR6MZQ7ONRE4KSI5TUK33WUHF7JGZ7QQ X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640282422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=l0fTutx40cLN9/6pVM6gZFsNAI8pVchGrcsJwAciUx4=; b=ZsNvg+VyG990ZDtEybqa/wvu9G0O48cYmrgvJf4g5mlcXFI+iZFjhueKRPnuzWGDGkzFza zwa00ifntMl3TYpqRdCAvWEXjc9cSsMZ5xTU9jNvhzuht0PLyLWrWzNyj95A/I5QDfIE2H JFi9iOVOPMRpiRQKArYtsC3qUl/HPyvrVM++sEs12lX7Y74zMboxNohjLASq557D4WLBp+ CN1WuXpJcQ3W5CwIOFtLPnaCqSqZE9FmUPWGvmRG77uRh9LXBktWgAeZz/hr6WIrXSPCFi DY7XDnepbzqRUN9dqXjn55eSkMYiXjWjTEBZliTNSClDtoYRtev0Fc4zi8nwQA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640282422; a=rsa-sha256; cv=none; b=chnx8xCuYTUR5M3SdU2iCjfk8mXrOsTqRMFHI9/muN/CtY9k7dcMh9bHsZJPM/y+522oL7 yHnP5NeZPi8std/5QQvLpe3PAn/fzMbY6knarIYOTK9ydFbhyHT+7qLecWDp2PF/Sdl02u lJenF4CZgNX7iej7XlWRD+tVa9MCr3bcoQVqOKqMgey1mXhBAe/9Hz8grmO6ldDQjhgnvF cfCwEm9SC/VIT/3pTOBl11TYHH8UEHh8M5m3EtD9nvCnOYW/a3Sn6sb1EYBpcC0ZUAoJwa EMe9+0Y2KrcNRrLOLwoedsOiXaQJ67EjqLOMgM5gRYwOHvdyRXignZdvEKbI4Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.15 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: C138129DD7 X-Spam-Score: -2.15 X-Migadu-Scanner: scn0.migadu.com X-TUID: XmS6uI62cfJc "Naveen N. Rao" writes: > David Bremner wrote: >> David Bremner writes: >> >>> At least some of this mail data is public, but I'm not sure if the bad >>> threading is reproducible or not; I want to run a complete census >>> overnight before I reindex. >>> >>> Even if the bug is non-deterministic, it probably lives in lib/add-message.cc >> >> I have a reproducible test for this bug now >> >> http://pivot.cs.unb.ca/git?p=notmuch.git;a=shortlog;h=refs/heads/fix/thread-search > > Thanks for looking into this. > >> >> I still need to analyze the mails a bit more, but it looks like at least >> one of the strange results is caused by multiple mail files sharing the >> same message-id, but with different References headers (and no >> In-Reply-To headers). > > In my case, I seem to be having the In-Reply-To headers. I end up with > two files per message: one from my inbox and one from the gmane archive > that I pull in. All the messages from the gmane archive seem to have a > re-written 'In-Reply-To' header, but 'Message-Id' and 'References' are > the same. > > In the problematic email thread, all other files/messages get allotted a > single thread except for one of the messages. The offending message has > 3 references compared to 1 or 2 references for the rest, but I don't > know if that's relevant here. > I _think_ this problem has been resolved with 3f4de98e7c8 / dab32dc70c15, so in releases after 0.32.2. At least the tests I had previously for it are passing in current notmuch.