unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
	notmuch@notmuchmail.org
Subject: Re: 'notmuch search thread:<>' lists multiple threads
Date: Thu, 23 Dec 2021 14:00:12 -0400	[thread overview]
Message-ID: <87bl17i4lv.fsf@tethera.net> (raw)
In-Reply-To: <1524045467.a0aq8zermb.naveen@linux.ibm.com>

"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> writes:

> David Bremner wrote:
>> David Bremner <david@tethera.net> writes:
>> 
>>> At least some of this mail data is public, but I'm not sure if the bad
>>> threading is reproducible or not; I want to run a complete census
>>> overnight before I reindex.
>>>
>>> Even if the bug is non-deterministic, it probably lives in lib/add-message.cc
>> 
>> I have a reproducible test for this bug now
>> 
>>   http://pivot.cs.unb.ca/git?p=notmuch.git;a=shortlog;h=refs/heads/fix/thread-search
>
> Thanks for looking into this.
>
>> 
>> I still need to analyze the mails a bit more, but it looks like at least
>> one of the strange results is caused by multiple mail files sharing the
>> same message-id, but with different References headers (and no
>> In-Reply-To headers).
>
> In my case, I seem to be having the In-Reply-To headers. I end up with 
> two files per message: one from my inbox and one from the gmane archive 
> that I pull in. All the messages from the gmane archive seem to have a 
> re-written 'In-Reply-To' header, but 'Message-Id' and 'References' are 
> the same.
>
> In the problematic email thread, all other files/messages get allotted a 
> single thread except for one of the messages. The offending message has 
> 3 references compared to 1 or 2 references for the rest, but I don't 
> know if that's relevant here.
>

I _think_ this problem has been resolved with 3f4de98e7c8 /
dab32dc70c15, so in releases after 0.32.2.

At least the tests I had previously for it are passing in current
notmuch.

  parent reply	other threads:[~2021-12-23 18:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-06  9:46 'notmuch search thread:<>' lists multiple threads Naveen N. Rao
2018-04-06 10:23 ` Naveen N. Rao
2018-04-08  3:04 ` David Bremner
2018-04-09 11:54   ` David Bremner
2018-04-10  1:45     ` [PATCH] devel: add new tool to draw thread structure David Bremner
2018-10-08  3:30       ` Daniel Kahn Gillmor
2018-04-18 10:18     ` 'notmuch search thread:<>' lists multiple threads Naveen N. Rao
2018-04-22  0:45       ` David Bremner
2018-06-28 10:36         ` Naveen N. Rao
2018-06-30 13:42           ` David Bremner
2018-08-30 12:52             ` David Bremner
2018-09-06 10:50               ` Naveen N. Rao
2019-06-27 14:45                 ` Naveen N. Rao
2019-06-27 14:53                   ` Naveen N. Rao
2021-12-23 18:00       ` David Bremner [this message]
2022-01-14 11:26         ` Naveen N. Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bl17i4lv.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).