From: Jose Antonio Ortega Ruiz <jao@gnu.org>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: use query name for tree saved-search buffer names
Date: Mon, 10 Jan 2022 03:16:39 +0000 [thread overview]
Message-ID: <87bl0k46w8.fsf@gnus.jao.io> (raw)
In-Reply-To: <87mtk41hj8.fsf@tethera.net>
On Sun, Jan 09 2022, David Bremner wrote:
> jao <jao@gnu.org> writes:
>
>> This simply mimics what we already do for non-tree searches, and makes
>> up for nicer buffer names. Note that this patch only applies to
>> queries not coming from a search widget in the hello buffer.
>>
>
> Two questions:
>
> 1) Should this actually approximate what we do in
> #'notmuch-search-buffer-title ? The buffer gets a name like
> "*notmuch-saved-search-inbox*"
oh, you're right. i have that function advised (because i prefer using
the unadorned query name), and thought i was being consistent. i think
we should. maybe we could consider adding a customizable format string
with default "*notmuch-saved-search-inbox-%s*" for cases like mine?
> 2) Should we do the same thing (whatever that is) for unthreaded mode
> searches?
i don't see any reason not to. i'll be happy to send a patch for both
cases.
cheers,
jao
--
Whenever you commend, add your reasons for doing so; it is this which
distinguishes the approbation of a man of sense from the flattery of
sycophants and admiration of fools. -Richard Steele (1672-1729)
next prev parent reply other threads:[~2022-01-10 3:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-08 20:41 [PATCH] emacs: use query name for tree saved-search buffer names jao
2022-01-09 1:58 ` Jose Antonio Ortega Ruiz
2022-01-10 1:55 ` David Bremner
2022-01-10 3:16 ` Jose Antonio Ortega Ruiz [this message]
2022-01-10 12:01 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl0k46w8.fsf@gnus.jao.io \
--to=jao@gnu.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).