From: Leo Okawa Ericson <git@relevant-information.com>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 1/2] emacs: Make indentation more consistent in notmuch-search-show-thread
Date: Tue, 03 May 2022 16:56:10 +0200 [thread overview]
Message-ID: <87bkwe3bsl.fsf@relevant-information.com> (raw)
In-Reply-To: <m2bkwey9xz.fsf@guru.guru-group.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> To me it looks like this change "breaks" indentation -- the original
> where all function (notmuch-show) arguments are aligned vertically,
> starting from same column in each line...???
>
Argh, it was me that was stupid. I had nameless-mode activated which
affects indentation. Please ignore that commit then (I'll retract it
with the next re-roll) and apologies for the inconvenience.
>>
>> base-commit: e3ad0087f3453c89871acac8b11da8bab1ac54df
>
> btw: what is this 'base commit:' line ?
>
It's included in the patch by git-format-patch. I think it helps git to
know on which commit to apply these patches to. Other projects mandated
that option so I have it on by default.
/Leo
prev parent reply other threads:[~2022-05-03 14:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 15:18 [PATCH v2 1/2] emacs: Make indentation more consistent in notmuch-search-show-thread Leo Okawa Ericson
2022-05-02 15:18 ` [PATCH v2 2/2] emacs: Make notmuch-show-next-thread return nil on failure Leo Okawa Ericson
2022-05-03 14:20 ` [PATCH v2 1/2] emacs: Make indentation more consistent in notmuch-search-show-thread Tomi Ollila
2022-05-03 14:56 ` Leo Okawa Ericson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkwe3bsl.fsf@relevant-information.com \
--to=git@relevant-information.com \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).