From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id eLMDNVYC7mXzoQAA62LTzQ:P1 (envelope-from ) for ; Sun, 10 Mar 2024 19:56:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id eLMDNVYC7mXzoQAA62LTzQ (envelope-from ) for ; Sun, 10 Mar 2024 19:56:23 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=kisara.moe header.s=default header.b=MQFhLwwP; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=fail reason="SPF not aligned (relaxed)" header.from=kisara.moe (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1710096982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=NRbxVKyfa1WodNDWDZh1b+JKgR5zCe4Et0Htcb2orF4=; b=fVg35W83gc5Y2PiGV1qWz9uc8Bk/i2EuOyShtGWGaZd70AVLQfgWyLx7D9w9wyEqZxFkvk gE6C46VdDlFQmrT6XjJ+Qzs9cT7tOza46EHs3dd/Ev2vNU20g+z/2ldWf9sYrslXRF2qQi NUCnHBN0oNrpZVJBG9aMPdZFYevAszErza7y6dfZs9tTjWwRX1tp/umynR3I6nHewe2mXR nqyF5AhFTXp9TWcekbD42rRyj0RFyj4pmSRkPe7cvbMYmCbwMPFUuN+DaJ/ODwGpZCeO1q 1tcElkneXuLcKh+kzqP29m+1ab/K3pmMIsrFqdWwbwURNX3bP8CxoABMkUFgfA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=kisara.moe header.s=default header.b=MQFhLwwP; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=fail reason="SPF not aligned (relaxed)" header.from=kisara.moe (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1710096982; a=rsa-sha256; cv=none; b=u3h8Mi04egXVkUD243fmOZvaQfWJfgwRRPlynAVETkZPtYcfRaWNh0EbmtQ/v34KCKaKMH 5iP6bbLByMgyfq5k+NbP7/H8FNwKwLNSTajCYvgJdpiibeUGBUxB4huvu2L5hgmIuRe1fu iJ1AbQ2oVM2KRqPFjj/ebgSSA8DmmPtcd2OcgXA5ljp6t4c8ZH+wrufrVFYgOokdYvzXvB OTDZylbTIOh+J1bA5hZEoDd2hgQbFT8SjKhB2Z0ItBXVsEo9jWCYH4xflQaObi5a7lFZ6u Hl3qkEbL3SoUlcliOxCLCJO3V5CFNz/kULdh9DkBGVoSOqK4aSFdgJFcWSYu4A== Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CDB0513F94 for ; Sun, 10 Mar 2024 19:56:20 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id A39325E511; Sun, 10 Mar 2024 18:56:16 +0000 (UTC) X-Greylist: delayed 476 seconds by postgrey-1.36 at yantan; Sun, 10 Mar 2024 18:56:13 UTC Received: from mail.kisara.moe (119.ip-51-38-65.eu [51.38.65.119]) by mail.notmuchmail.org (Postfix) with ESMTPS id BBACD5E50A for ; Sun, 10 Mar 2024 18:56:13 +0000 (UTC) Received: from mk-desktop (05408574.skybroadband.com [5.64.133.116]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mail.kisara.moe (Postfix) with ESMTPSA id 5D15BA2796; Sun, 10 Mar 2024 19:48:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kisara.moe; s=default; t=1710096496; bh=mFse062PGPA2hAStey5BlAK3SocUKiUNUCwXfMHvP+M=; h=From:To:Subject:In-Reply-To:References:Date:From; b=MQFhLwwP3EY+skcL1FNBcUlYLNO6p5f8Jfef4gZjqh57F/qRGR3EZHtUz609MpIFJ 560zQgW4ZplOlFmL4RZ5vXxVUdNlwM4X0V8xVa2QhhQFgx6joWUzXqVin3BggbeClc +ScGDVNSZ2KjYWBMy+XCHkTQy5oevtKSRlaBtPU/MTzlHaJZNahO4yzsM0W+ln/p+I CB5S7uBxkgenvi8eJBX1pKGdpwOtsxJuc2dgy1LziQvY44+vd/6fJwVDjmdmMHCFfb XyiLc8ZGQxwPWQw20z1Gj2FJ/bIWmpiKVhrTosE9vU4aMirRm8sVvWt9E6PbtxYhm4 0YJu9wWldXx0A== From: Mohsin Kaleem To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH v2 2/3] emacs: Allow notmuch-saved-searches to hide excluded messages In-Reply-To: <87mt2gp8g7.fsf@tethera.net> References: <87v8re66mg.fsf@tethera.net> <20230416131811.658253-1-mohkale@kisara.moe> <20230416131811.658253-3-mohkale@kisara.moe> <87mt2gp8g7.fsf@tethera.net> Date: Sun, 10 Mar 2024 18:48:14 +0000 Message-ID: <87bk7ludn5.fsf@kisara.moe> MIME-Version: 1.0 Message-ID-Hash: 3WV5YWRYND7XCNPZAQOVCHZCM6GRL33J X-Message-ID-Hash: 3WV5YWRYND7XCNPZAQOVCHZCM6GRL33J X-MailFrom: mohkale@kisara.moe X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0 X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE X-Migadu-Spam-Score: 0.44 X-Spam-Score: 0.44 X-Migadu-Queue-Id: CDB0513F94 X-Migadu-Scanner: mx13.migadu.com X-TUID: Tq/ymyPR71gl David Bremner writes: Hi, sorry, took me so long to get back to this XD. I've opted to squash the 3 separate commits in this patch series into one commit so that should address the commit message questions. > mohkale@kisara.moe writes: > >> + :excluded Whether to show mail with excluded tags in the >> + search. Possible values are `hide', `show', >> + or nil. Nil means use the default value of >> + `notmuch-search-hide-excluded'. > > So if I understand correctly, toggling excludes will not affect saved > searches with a :excluded key. Is this what we want? > > I guess the alternative is to AND notmuch-search-hide-excluded with the > value derived from the saved-search? I think this is the last pending question. This shouldn't be the case. When you open a search from notmuch saved searches it'll contain whatever value you specify in :excluded but you can interactively change that with the new toggle-exclude commands and the workflow should be as you expect. I did notice while testing this that notmuch-jump currently doesn't respect the exclude option you add to saved searches but I've addressed that in this next patch version. -- Mohsin Kaleem