From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 641A6431FBD; Tue, 1 Dec 2009 19:01:45 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SULmnQ6B-1oe; Tue, 1 Dec 2009 19:01:43 -0800 (PST) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 10EFE431FAE; Tue, 1 Dec 2009 19:01:43 -0800 (PST) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id 66B9625438C; Tue, 1 Dec 2009 19:01:25 -0800 (PST) From: Carl Worth To: djcb@djcbsoftware.nl In-Reply-To: <87638qbkbo.wl%djcb@djcbsoftware.nl> References: <87r5rpyd4x.wl%djcb@djcbsoftware.nl> <87k4x6ad94.fsf@yoom.home.cworth.org> <87638qbkbo.wl%djcb@djcbsoftware.nl> Date: Tue, 01 Dec 2009 19:01:24 -0800 Message-ID: <87aay29j0b.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Cc: "notmuch@notmuchmail org" Subject: Re: [PATCH 2/2] * avoid gcc 4.4.1 compiler warning due to ignored 'fflush' return value X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2009 03:01:45 -0000 --=-=-= On Tue, 01 Dec 2009 20:50:03 +0200, Dirk-Jan C. Binnema wrote: > Sure, that's the better solution, but note that my patch did not introduce the > undefined behavior -- it was there before. I was trying a minimal patch to > silencing the warning. Yes, the leak was my bug. And the warning was useful to point to the bug. That's why silencing it would have been a bad thing. > Note that prompt seems to leak a bit, even after the > committed patch; attached are two more micro patches to fix this and another > small leak. I try to do minimal changes, but the prompt business gets a bit > unwieldy. The leaks are one-time at not critical, but anyway it's always good > stay vigilant. Yes, leak fixes are always appreciated. Could you resend these as complete git commits? I see only git diffs which lack both authorship and commit messages. Also, if you can send patches as text/plain rather than application/octet-stream then it's much easier to review them by simply replying and having the patch be quoted in the reply. Thanks, -Carl --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFLFdiF6JDdNq8qSWgRAi8AAJ40iKiiXGyQ+Kr5A+eoF1ZSg4OH8QCeM3oI vd4FfixyUdtRMWVmlPoPxng= =3Q1G -----END PGP SIGNATURE----- --=-=-=--