Re: [PATCH 2/2] * avoid gcc 4.4.1 compiler warning due to ignored 'fflush' return value

[Carl Worth <cworth@cworth.org>]

[-- Attachment #1: Type: text/plain, Size: 1065 bytes --]

On Tue, 01 Dec 2009 20:50:03 +0200, Dirk-Jan C. Binnema <djcb.bulk@gmail.com> wrote:
> Sure, that's the better solution, but note that my patch did not introduce the
> undefined behavior -- it was there before. I was trying a minimal patch to
> silencing the warning.

Yes, the leak was my bug.

And the warning was useful to point to the bug. That's why silencing it
would have been a bad thing.

> Note that prompt seems to leak a bit, even after the
> committed patch; attached are two more micro patches to fix this and another
> small leak. I try to do minimal changes, but the prompt business gets a bit
> unwieldy. The leaks are one-time at not critical, but anyway it's always good
> stay vigilant.

Yes, leak fixes are always appreciated.

Could you resend these as complete git commits? I see only git diffs
which lack both authorship and commit messages.

Also, if you can send patches as text/plain rather than
application/octet-stream then it's much easier to review them by simply
replying and having the patch be quoted in the reply.

Thanks,

-Carl

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]