Re: [PATCH 2/3] notmuch.el: Add collapse all and expand all to notmuch-show

[Carl Worth <cworth@cworth.org>]

[-- Attachment #1: Type: text/plain, Size: 1389 bytes --]

On Tue,  1 Dec 2009 14:17:32 +0800, Kan-Ru Chen <kanru@kanru.info> wrote:
> These two functions behave like gmail's collapse all and expand all
> commands. notmuch-show-collapse-all is bound to 'B' but
> notmuch-show-expand-all has no keybindig because I thought it is not often
> used.

I haven't applied this one for a few reasons:

1. I don't know what the functions are support to do.

   The commit log says "behave like gmail" but I don't know what that
   means personally. And the functions don't have any documentation
   strings.

   I assume that these functions are either showing or hiding all
   message bodies in the current thread?

2. You provided a binding for collapse, but not expand. I don't like
   functionality which lets a user hide a bunch of data, and then not be
   able to get it back---that's really annoying if the user hits the key
   accidentally.

   Personally, I think I'd be much more likely to use expand before
   collapse, (for example, to easily see the context when a new message
   arrives in a thread that I'd previously read so comes up collapsed by
   default).

Should we perhaps make something which temporarily makes all hidden
messages visible but then toggles back to the previous subset of some
show messages? Once again, I'm worried about providing trapdoor
interfaces where the user can't get back to the previous state easily.

-Carl

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]