[PATCH] emacs: "message-cited-text-face" is obsolete since Emacs 22.1. Use "message-cited-text" instead.

[PATCH] emacs: "message-cited-text-face" is obsolete since Emacs 22.1. Use "message-cited-text" instead.

[Pieter Praet]

---
 emacs/notmuch-wash.el |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch-wash.el b/emacs/notmuch-wash.el
index c4a7a41..0e64eb2 100644
--- a/emacs/notmuch-wash.el
+++ b/emacs/notmuch-wash.el
@@ -125,7 +125,7 @@ is what to put on the button."
     (let* ((cite-start (match-beginning 0))
 	   (cite-end (match-end 0))
 	   (cite-lines (count-lines cite-start cite-end)))
-      (overlay-put (make-overlay cite-start cite-end) 'face 'message-cited-text-face)
+      (overlay-put (make-overlay cite-start cite-end) 'face 'message-cited-text)
       (when (> cite-lines (+ notmuch-wash-citation-lines-prefix
 			     notmuch-wash-citation-lines-suffix
 			     1))
@@ -151,7 +151,7 @@ is what to put on the button."
 		  (sig-end-marker (make-marker)))
 	      (set-marker sig-start-marker sig-start)
 	      (set-marker sig-end-marker (point-max))
-	      (overlay-put (make-overlay sig-start-marker sig-end-marker) 'face 'message-cited-text-face)
+	      (overlay-put (make-overlay sig-start-marker sig-end-marker) 'face 'message-cited-text)
 	      (notmuch-wash-region-to-button
 	       sig-start-marker sig-end-marker
 	       "signature" "\n"
---

Re: [PATCH] emacs: "message-cited-text-face" is obsolete since Emacs 22.1. Use "message-cited-text" instead.

[David Bremner]

Hi Pieter;

Thanks a lot for the the patch.  I notice there is no commit message in
the body, so I suspect the chances of Carl applying it as-is are pretty
remote. Of course I could be off-base, but we've had many patches in the
past go back for improved commit messages.

All the best,

David

[PATCH 0/1] emacs: Use "message-cited-text" instead of "message-cited-text-face"

[Pieter Praet]

On Wed, 16 Mar 2011 08:20:24 -0300, David Bremner <bremner@unb.ca> wrote:
> [...] I notice there is no commit message in the body, so I suspect
> the chances of Carl applying it as-is are pretty remote. [...]

David,

Thanks for the heads up!

Guess I should've read the patch submission guidelines first...

Peace

-Pieter

[PATCH 1/1] emacs: Use "message-cited-text" instead of "message-cited-text-face"

[Pieter Praet]

(describe-face 'message-cited-text-face)
> message-cited-text-face is an alias for the face `message-cited-text'.
> This face is obsolete since 22.1; use `message-cited-text' instead.

Signed-off-by: Pieter Praet <pieter@praet.org>
---
 emacs/notmuch-wash.el |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch-wash.el b/emacs/notmuch-wash.el
index c4a7a41..0e64eb2 100644
--- a/emacs/notmuch-wash.el
+++ b/emacs/notmuch-wash.el
@@ -125,7 +125,7 @@ is what to put on the button."
     (let* ((cite-start (match-beginning 0))
 	   (cite-end (match-end 0))
 	   (cite-lines (count-lines cite-start cite-end)))
-      (overlay-put (make-overlay cite-start cite-end) 'face 'message-cited-text-face)
+      (overlay-put (make-overlay cite-start cite-end) 'face 'message-cited-text)
       (when (> cite-lines (+ notmuch-wash-citation-lines-prefix
 			     notmuch-wash-citation-lines-suffix
 			     1))
@@ -151,7 +151,7 @@ is what to put on the button."
 		  (sig-end-marker (make-marker)))
 	      (set-marker sig-start-marker sig-start)
 	      (set-marker sig-end-marker (point-max))
-	      (overlay-put (make-overlay sig-start-marker sig-end-marker) 'face 'message-cited-text-face)
+	      (overlay-put (make-overlay sig-start-marker sig-end-marker) 'face 'message-cited-text)
 	      (notmuch-wash-region-to-button
 	       sig-start-marker sig-end-marker
 	       "signature" "\n"
-- 
1.7.1

Re: [PATCH 1/1] emacs: Use "message-cited-text" instead of "message-cited-text-face"

[Jameson Graef Rollins]

[-- Attachment #1: Type: text/plain, Size: 123 bytes --]

Hi, Pieter.  I applied this patch to the release-candidate/0.6 branch.
Thanks for sending it in, and fixing it up.

jamie.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]