unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] Fix old style notmuch-fcc-dirs configuration check.
@ 2011-05-09 16:04 Dmitry Kurochkin
  2011-05-09 16:32 ` Jameson Graef Rollins
  0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Kurochkin @ 2011-05-09 16:04 UTC (permalink / raw)
  To: Notmuch Mail

In notmuch 0.5 notmuch-fcc-dirs style changed.  The previous code
did not correctly identify an old configuration and, as a
consequence, broke new configurations.

The fix was extracted from a bigger patch series by David
Edmondson id:"1290682750-30283-2-git-send-email-dme@dme.org".
---

The patch is for the release-candidate/0.6 branch.

Regards,
  Dmitry


 emacs/notmuch-maildir-fcc.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el
index aede753..b6c6e2a 100644
--- a/emacs/notmuch-maildir-fcc.el
+++ b/emacs/notmuch-maildir-fcc.el
@@ -88,7 +88,7 @@ will NOT be removed or replaced."
 	   notmuch-fcc-dirs)
 
 	  ((and (listp notmuch-fcc-dirs)
-		(= 1 (length (car notmuch-fcc-dirs))))
+		(stringp (car notmuch-fcc-dirs)))
 	   ;; Old style - no longer works.
 	   (error "Invalid `notmuch-fcc-dirs' setting (old style)"))
 
-- 
1.7.5.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix old style notmuch-fcc-dirs configuration check.
  2011-05-09 16:04 [PATCH] Fix old style notmuch-fcc-dirs configuration check Dmitry Kurochkin
@ 2011-05-09 16:32 ` Jameson Graef Rollins
  0 siblings, 0 replies; 2+ messages in thread
From: Jameson Graef Rollins @ 2011-05-09 16:32 UTC (permalink / raw)
  To: Dmitry Kurochkin, Notmuch Mail

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

On Mon,  9 May 2011 20:04:54 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> In notmuch 0.5 notmuch-fcc-dirs style changed.  The previous code
> did not correctly identify an old configuration and, as a
> consequence, broke new configurations.
> 
> The fix was extracted from a bigger patch series by David
> Edmondson id:"1290682750-30283-2-git-send-email-dme@dme.org".

Thanks for extracting the needed fix, Dmitry.  This makes things much
easier.  Applied to r-c/0.6

jamie.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-09 16:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-09 16:04 [PATCH] Fix old style notmuch-fcc-dirs configuration check Dmitry Kurochkin
2011-05-09 16:32 ` Jameson Graef Rollins

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).