unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] test: use emacsclient(1) for Emacs tests
Date: Tue, 28 Jun 2011 07:59:48 +0400	[thread overview]
Message-ID: <87aad2zjuz.fsf@gmail.com> (raw)
In-Reply-To: <20110628034937.GB4120@mit.edu>

On Mon, 27 Jun 2011 23:49:37 -0400, Austin Clements <amdragon@MIT.EDU> wrote:
> Quoth Dmitry Kurochkin on Jun 28 at  5:03 am:
> > > >  The only way I know to
> > > > reliably kill a child process is to open a pipe to it and have it exit
> > > > on its own when it reads EOF.  Unfortunately, I couldn't find a way to
> > > > do this with an emacs daemon (it appears daemon mode aggressively
> > > > cleans up things like pipes), but here's a different approach:
> > > > 
> > > >     coproc emacs --batch --eval "(while t (eval (read)))"
> > > >     EMACSFD=${COPROC[1]}
> > > >     trap "echo '(kill-emacs)' >&$EMACSFD" EXIT
> > > > 
> > > >     echo '(message "Hi")' >&$EMACSFD
> > > >     # ...
> > > > 
> > > > This is, basically, a poor man's emacs server, but the coprocess pipe
> > > > binds it tightly to the shell.  If the shell exits for *any* reason,
> > > > the pipe will be closed by the kernel, emacs will read an EOF, and
> > > > exit.
> > > 
> > > I like this idea.
> > > 
> > > >  The trap is there just to cleanly shut down in case of a normal
> > > > exit [1].
> > > 
> > > For normal exit we should just put this into test_done.  Otherwise it is
> > > not a normal exit and we do not care about Emacs error message.  No?
> > > 
> > > >  This also has the advantage that read-from-minibuffer still
> > > > works:
> > > > 
> > > >     echo '(message (read-from-minibuffer ""))' >&$EMACSFD
> > > >     echo 'Test' >&$EMACSFD
> > > > 
> > > > Thoughts?
> > > > 
> > > 
> > > I like it and I will implement it.  Thanks for the idea.
> > > 
> > 
> > While implementing the idea, I stumbled upon a problem: we need to know
> > when Emacs finished what we echoed or failed with an error.  At the
> > moment tests fail because they check for OUTPUT before Emacs creates it.
> > 
> > We can tell Emacs to print some special marker and wait for it.  But
> > there may be exceptions and errors which may make it difficult.  I did
> > not found a good solution yet.  Would love to hear your thoughts :)
> 
> Oof, yes, of course.  How about making the one-line poor man's emacs
> server slightly less poor?  Use a FIFO to communicate completion.
> Something like,
> 
> EMACSDONE=$TEST_DIRECTORY/emacsdone
> mkfifo $EMACSDONE
> coproc emacs --batch --eval '(while t (eval (read)) (write-region "\n" nil "'$EMACSDONE'" t 0))'
> EMACSFD=${COPROC[1]}
> 
> test_emacs() {
>     echo "$1" >&$EMACSFD
>     read <$EMACSDONE
> }
> 
> test_emacs '(sleep-for 2)'
> test_emacs '(message "Hi")'
> 
> echo '(kill-emacs)' >&$EMACSFD

I am sure that would work, but I do not like the complexity.  How about
getting back to standard emacsclient and running a watchdog in the
emacs?  Like:

(defun orphan-watchdog (pid)
  "Periodically check that the process with id PID is still
running, quit if it terminated."
  (if (not (process-attributes pid))
      (kill-emacs)
    (run-at-time "1 min" nil orphan-watchdog pid)))

This function (or my other changes) do not work (by yet unknown reason
:)), but you get the idea.

Regards,
  Dmitry

  reply	other threads:[~2011-06-28  3:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-26 23:52 [PATCH 1/5] test: do not set `message-signature' in test_emacs Dmitry Kurochkin
2011-06-26 23:52 ` [PATCH 2/5] test: cleanup test_emacs Dmitry Kurochkin
2011-06-26 23:52 ` [PATCH 3/5] test: wrap and indent test_emacs calls Dmitry Kurochkin
2011-06-26 23:52 ` [PATCH 4/5] test: save buffer content to file instead of printing it in Emacs tests Dmitry Kurochkin
2011-06-26 23:52 ` [PATCH 5/5] test: remove some sed(1) calls " Dmitry Kurochkin
2011-06-27  3:54 ` [PATCH 1/2] test: use emacs_deliver_message in Emacs SMTP send test Dmitry Kurochkin
2011-06-27  3:54   ` [PATCH 2/2] test: use emacsclient(1) for Emacs tests Dmitry Kurochkin
2011-06-27 20:02     ` Austin Clements
2011-06-27 20:22       ` Dmitry Kurochkin
2011-06-27 20:32         ` Austin Clements
2011-06-28  1:03         ` Dmitry Kurochkin
2011-06-28  3:49           ` Austin Clements
2011-06-28  3:59             ` Dmitry Kurochkin [this message]
2011-06-28  4:17               ` Austin Clements
2011-06-28  4:44                 ` Dmitry Kurochkin
2011-06-28 16:22             ` Austin Clements
2011-06-28 16:42               ` Dmitry Kurochkin
2011-06-28 20:10                 ` Carl Worth
2011-06-28 20:47                   ` Dmitry Kurochkin
2011-06-28 22:41                     ` Carl Worth
2011-06-28 20:58                   ` Dmitry Kurochkin
2011-06-28 22:42                     ` Carl Worth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87aad2zjuz.fsf@gmail.com \
    --to=dmitry.kurochkin@gmail.com \
    --cc=amdragon@MIT.EDU \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).