From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 7187D431FD0 for ; Tue, 20 Dec 2011 12:05:38 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SS+dfB9k31tH for ; Tue, 20 Dec 2011 12:05:37 -0800 (PST) Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com [74.125.83.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id A2473431FB6 for ; Tue, 20 Dec 2011 12:05:37 -0800 (PST) Received: by eekd41 with SMTP id d41so8152887eek.26 for ; Tue, 20 Dec 2011 12:05:36 -0800 (PST) Received: by 10.204.149.212 with SMTP id u20mr1405437bkv.120.1324411536181; Tue, 20 Dec 2011 12:05:36 -0800 (PST) Received: from localhost (dsl-hkibrasgw4-fe5cdc00-23.dhcp.inet.fi. [80.220.92.23]) by mx.google.com with ESMTPS id fa8sm6275186bkc.14.2011.12.20.12.05.33 (version=SSLv3 cipher=OTHER); Tue, 20 Dec 2011 12:05:34 -0800 (PST) From: Jani Nikula To: notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: create patch filename from subject for inline patch fake parts In-Reply-To: <1321657368-13872-1-git-send-email-jani@nikula.org> References: <1321657368-13872-1-git-send-email-jani@nikula.org> User-Agent: Notmuch/0.10.2+114~gf57278c (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu) Date: Tue, 20 Dec 2011 22:05:31 +0200 Message-ID: <87aa6nxb3o.fsf@nikula.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2011 20:05:38 -0000 Shameless promotion of own patches... I suppose not many use the notmuch-wash-convert-inline-patch-to-part option, but with this patch I've actually started to like it better. An actual patch name from subject instead of "inline patch". As I said, the lisp is less than perfect here, but this is still better than what's existing. Any comments? BR, Jani. On Sat, 19 Nov 2011 01:02:48 +0200, Jani Nikula wrote: > Use the mail subject line for creating a descriptive filename for the wash > generated inline patch fake parts. The names are similar to the ones > created by 'git format-patch', just without the leading numbers. > > Signed-off-by: Jani Nikula > > --- > > I know notmuch-subject-to-patch-filename is totally un-lispy. Suggestions > welcome on how to make it lispy and keep it somewhat readable. > > If we later want to have a '>' counterpart to '|' to save messages to files > rather than pipe, then this could be generalized and re-used for creating > the suggested filename for that. > > I don't even use the notmuch-wash-convert-inline-patch-to-part option that > much, but having it suggest "inline patch" as filename is just ugly... > --- > emacs/notmuch-wash.el | 16 +++++++++++++++- > 1 files changed, 15 insertions(+), 1 deletions(-) > > diff --git a/emacs/notmuch-wash.el b/emacs/notmuch-wash.el > index 1f420b2..755d64a 100644 > --- a/emacs/notmuch-wash.el > +++ b/emacs/notmuch-wash.el > @@ -290,6 +290,17 @@ When doing so, maintaining citation leaders in the wrapped text." > > (defvar diff-file-header-re) ; From `diff-mode.el'. > > +(defun notmuch-subject-to-patch-filename (str) > + "Convert a typical patch mail subject line into a suitable filename." > + (let ((s str)) > + (setq s (replace-regexp-in-string "^ *\\(\\[[^]]*\\]\\)? *" "" s)) > + (setq s (replace-regexp-in-string "[. ]*$" "" s)) > + (setq s (replace-regexp-in-string "[^A-Za-z0-9._-]+" "-" s)) > + (setq s (replace-regexp-in-string "\\.+" "." s)) > + (when (> (length s) 52) > + (setq s (substring s 0 52))) > + (concat s ".patch"))) > + > (defun notmuch-wash-convert-inline-patch-to-part (msg depth) > "Convert an inline patch into a fake 'text/x-diff' attachment. > > @@ -316,7 +327,10 @@ for error." > (setq part (plist-put part :content-type "text/x-diff")) > (setq part (plist-put part :content (buffer-string))) > (setq part (plist-put part :id -1)) > - (setq part (plist-put part :filename "inline patch")) > + (setq part (plist-put part :filename > + (notmuch-subject-to-patch-filename > + (plist-get > + (plist-get msg :headers) :Subject)))) > (delete-region (point-min) (point-max)) > (notmuch-show-insert-bodypart nil part depth)))))) > > -- > 1.7.5.4 >