From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 19585429E30 for ; Thu, 12 Jan 2012 09:20:30 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TWGOd6uvZErD for ; Thu, 12 Jan 2012 09:20:29 -0800 (PST) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 5FAD9429E29 for ; Thu, 12 Jan 2012 09:20:29 -0800 (PST) Received: by wibhr12 with SMTP id hr12so1510658wib.26 for ; Thu, 12 Jan 2012 09:20:28 -0800 (PST) Received: by 10.180.97.73 with SMTP id dy9mr7764187wib.11.1326388828162; Thu, 12 Jan 2012 09:20:28 -0800 (PST) Received: from localhost ([109.131.126.209]) by mx.google.com with ESMTPS id q7sm947678wix.5.2012.01.12.09.20.26 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 12 Jan 2012 09:20:27 -0800 (PST) From: Pieter Praet To: Dmitry Kurochkin , Tomi Ollila , David Bremner , Notmuch Mail Subject: Re: Code Style Bikeshed 1/n: Break before Brace or Brace before Break? In-Reply-To: <87pqflj1l0.fsf@gmail.com> References: <87vcpeaxwv.fsf@zancas.localnet> <87ty4xj2ub.fsf@gmail.com> <87pqflj1l0.fsf@gmail.com> User-Agent: Notmuch/0.10.2+115~gadd29f6 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Thu, 12 Jan 2012 18:18:42 +0100 Message-ID: <87aa5sltzh.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2012 17:20:30 -0000 On Sun, 18 Dec 2011 20:18:03 +0400, Dmitry Kurochkin wrote: > On Sun, 18 Dec 2011 18:12:51 +0200, Tomi Ollila wrote: > > On Sun, 18 Dec 2011 19:50:52 +0400, Dmitry Kurochkin wrote: > > > +1 for the former. > > > > +1 > > > > > How about indenting with spaces+tabs vs indenting with spaces only? :) > > > > -1 -- tab-width is 8, anything else is heretic. Everyone enable > > git pre-commit hook :) > > > > Sorry, -1 for what? :) > > FWIW tabs make patch review a pain in our favourite interface to our > favourite mail system because of message indenting. > ~+1... Neither the tabs nor the spaces impede patch review from within Notmuch. The real cause of this confusing indentation is that we're using *both*, which -from my point of view- makes absolutely no sense. Personally, I'd like to see ;; -*- tab-width: 2; indent-tabs-mode: nil; -*- ... but frankly, I don't care whether it's tabs or spaces, or whether it's mod-2, mod-4 or mod-8... as long as it's *tabs XOR spaces*. And brace-before-break, of course... :) So, when's this bikeshed due to be delivered ? Also, if I order *now*, do I get a complementary cheese grater ? > Regards, > Dmitry > > > > Regards, > > > Dmitry > > > > Tomi Peace -- Pieter