From: Pieter Praet <pieter@praet.org>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
Tomi Ollila <tomi.ollila@iki.fi>,
David Bremner <david@tethera.net>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: Code Style Bikeshed 1/n: Break before Brace or Brace before Break?
Date: Thu, 12 Jan 2012 18:18:42 +0100 [thread overview]
Message-ID: <87aa5sltzh.fsf@praet.org> (raw)
In-Reply-To: <87pqflj1l0.fsf@gmail.com>
On Sun, 18 Dec 2011 20:18:03 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> On Sun, 18 Dec 2011 18:12:51 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> > On Sun, 18 Dec 2011 19:50:52 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > > +1 for the former.
> >
> > +1
> >
> > > How about indenting with spaces+tabs vs indenting with spaces only? :)
> >
> > -1 -- tab-width is 8, anything else is heretic. Everyone enable
> > git pre-commit hook :)
> >
>
> Sorry, -1 for what? :)
>
> FWIW tabs make patch review a pain in our favourite interface to our
> favourite mail system because of message indenting.
>
~+1...
Neither the tabs nor the spaces impede patch review from within Notmuch.
The real cause of this confusing indentation is that we're using *both*,
which -from my point of view- makes absolutely no sense.
Personally, I'd like to see
;; -*- tab-width: 2; indent-tabs-mode: nil; -*-
... but frankly, I don't care whether it's tabs or spaces, or whether
it's mod-2, mod-4 or mod-8... as long as it's *tabs XOR spaces*.
And brace-before-break, of course... :)
So, when's this bikeshed due to be delivered ?
Also, if I order *now*, do I get a complementary cheese grater ?
> Regards,
> Dmitry
>
> > > Regards,
> > > Dmitry
> >
> > Tomi
Peace
--
Pieter
next prev parent reply other threads:[~2012-01-12 17:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-18 12:04 Code Style Bikeshed 1/n: Break before Brace or Brace before Break? David Bremner
2011-12-18 15:50 ` Dmitry Kurochkin
2011-12-18 16:12 ` Tomi Ollila
2011-12-18 16:18 ` Dmitry Kurochkin
2012-01-12 17:18 ` Pieter Praet [this message]
2011-12-18 17:13 ` Austin Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aa5sltzh.fsf@praet.org \
--to=pieter@praet.org \
--cc=david@tethera.net \
--cc=dmitry.kurochkin@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).